-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Forbid inlining thread_local!
's __getit
function on Windows"
#104855
Conversation
This reverts commit 3099dfd.
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Oh hm. Yeah I think a revert is a good idea for now. Ultimately the TLS issues are a compiler bug so maybe trying to work around them in libs isn't going to be viable. @bors r+ |
Fixes ThinLTO on windows, so we should not let this sit around the queue for a long time. @bors p=1 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (af63e3b): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Revert of #101368, fixes #104852.
I'd rather not do this since that's a soundness fix and this is hitting some compiler bug, but I don't really know an alternative.
r? @ChrisDenton