Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement masking in FileType comparison on Unix #104901

Merged
merged 4 commits into from
Dec 10, 2022
Merged

Implement masking in FileType comparison on Unix #104901

merged 4 commits into from
Dec 10, 2022

Conversation

krtab
Copy link
Contributor

@krtab krtab commented Nov 25, 2022

Fixes: #104900

@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 25, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@the8472 the8472 assigned the8472 and unassigned joshtriplett Nov 30, 2022
@the8472
Copy link
Member

the8472 commented Nov 30, 2022

Looks reasonable, but since the associated issue has a reproducer can you add it to the std testsuite? There's a helper function to get a temporary directory for the test, the dir creation should happen inside that.

@krtab
Implement masking in FileType hashing on Unix
4198d29 
Commit 7700595 implemented masking of
FileType to fix an issue[^1] in the semantic of FileType comparison.
This commit introduces masking to Hash to maintain the invariant that
x == y => hash(x) == hash(y).

[^1]: rust-lang#104900
@the8472
Copy link
Member

the8472 commented Dec 9, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 9, 2022

📌 Commit 24cd863 has been approved by the8472

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2022
@krtab
Copy link
Contributor Author

krtab commented Dec 9, 2022

Thanks a lot for the review @the8472 !

@matthiaskrgr matthiaskrgr mentioned this pull request Dec 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2022
@bors
Auto merge of rust-lang#105525 - matthiaskrgr:rollup-ricyw5s, r=matth…
b12b836 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#98391 (Reimplement std's thread parker on top of events on SGX)
 - rust-lang#104019 (Compute generator sizes with `-Zprint_type_sizes`)
 - rust-lang#104512 (Set `download-ci-llvm = "if-available"` by default when `channel = dev`)
 - rust-lang#104901 (Implement masking in FileType comparison on Unix)
 - rust-lang#105082 (Fix Async Generator ABI)
 - rust-lang#105109 (Add LLVM KCFI support to the Rust compiler)
 - rust-lang#105505 (Don't warn about unused parens when they are used by yeet expr)
 - rust-lang#105514 (Introduce `Span::is_visible`)
 - rust-lang#105516 (Update cargo)
 - rust-lang#105522 (Remove wrong note for short circuiting operators)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eb1159c into rust-lang:master Dec 10, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the8472 the8472 the8472 left review comments

Assignees

@the8472 the8472

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

FileType PartialEq implementation is buggy on Unix
5 participants
@krtab @rustbot @the8472 @bors @joshtriplett