Ignore bivariant parameters in test_type_match. #104936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
cjgillot
force-pushed
the
self-rpit-orig-too
branch
from
822076c to
89afda7
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104804 (Rename `ast::Lit` as `ast::MetaItemLit`.) - rust-lang#104891 (Add documentation for `has_escaping_bound_vars`) - rust-lang#104933 (interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order) - rust-lang#104936 (Ignore bivariant parameters in test_type_match.) - rust-lang#104954 (make simple check of prinf function) - rust-lang#104956 (Avoid ICE if the Clone trait is not found while building error suggestions) - rust-lang#104982 (interpret: get rid of run() function) - rust-lang#104998 (Update my mailmap) - rust-lang#105006 (stricter alignment enforcement for ScalarPair) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…-obk Ignore bivariant parameters in test_type_match. rust-lang#103491 made opaque types bivariant with respect of some of their lifetime parameters. Because of this bivariance, some lifetime variables were not unified to anything during borrowck, and were considered as unequal by borrowck type test. This PR makes type test ignore the bivariant parameters in test_type_match. Fixes rust-lang#104815 r? `@oli-obk`
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104804 (Rename `ast::Lit` as `ast::MetaItemLit`.) - rust-lang#104891 (Add documentation for `has_escaping_bound_vars`) - rust-lang#104933 (interpret: remove PartialOrd from a bunch of types that do not have or need a sensible order) - rust-lang#104936 (Ignore bivariant parameters in test_type_match.) - rust-lang#104954 (make simple check of prinf function) - rust-lang#104956 (Avoid ICE if the Clone trait is not found while building error suggestions) - rust-lang#104982 (interpret: get rid of run() function) - rust-lang#104998 (Update my mailmap) - rust-lang#105006 (stricter alignment enforcement for ScalarPair) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#103491 made opaque types bivariant with respect of some of their lifetime parameters. Because of this bivariance, some lifetime variables were not unified to anything during borrowck, and were considered as unequal by borrowck type test.
This PR makes type test ignore the bivariant parameters in test_type_match.
Fixes #104815
r? @oli-obk