Uncomments out a reproducible build test #105075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that appears to now be working on Windows. Signed-off-by: Nell Shamrell <[email protected]>
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
nellshamrell
commented
Nov 29, 2022
| # Windows. | ||
| # See: https://github.com/rust-lang/rust/pull/87320#issuecomment-920105533 | ||
| # Issue: https://github.com/rust-lang/rust/issues/88982 | ||
| # This test appears to not be working on either Linux or Windows |
There was a problem hiding this comment.
To Do: Create a separate issue for this
|
Would it be possible for me to have |
|
Try doesn't test all platforms regardless, https://rustc-dev-guide.rust-lang.org/tests/ci.html has some discussion of how to enable the builders in PR CI. |
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
|
Got a failure on one of the Windows builders - investigating. |
|
@rustbot author
|
rustbot
added
S-waiting-on-author
|
Closing this for now - going to re-think my approach and open a new PR when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that appears to now be working on Windows.
I have been investigating (off and on for the past few months) #88982.
In the process, I found that one of the commented out tests does appear to pass now on my Windows workstation. However, the other test does not pass on either Linux or Windows.
Signed-off-by: Nell Shamrell [email protected]