-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clippy: backport ICE fix before beta branch #105470
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 8, 2022
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
@bors r+ p=1 |
🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 9, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 9, 2022
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#105216 (Remove unused GUI test) - rust-lang#105245 (attempt to clarify align_to docs) - rust-lang#105387 (Improve Rustdoc scrape-examples UI) - rust-lang#105389 (Enable profiler in dist-powerpc64le-linux) - rust-lang#105427 (Dont silently ignore rustdoc errors) - rust-lang#105442 (rustdoc: clean up docblock table CSS) - rust-lang#105443 (Move some queries and methods) - rust-lang#105455 (use the correct `Reveal` during validation) - rust-lang#105470 (Clippy: backport ICE fix before beta branch) - rust-lang#105474 (lib docs: fix typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…earth Clippy: backport ICE fix before beta branch r? `@Manishearth` Before beta is branched tomorrow we should backport the fix from rust-lang/rust-clippy#10027 for an ICE. That way we'll get this into stable one release sooner. This only cherry-picks the fix, not the tests for it. The proper sync of this will be done next week Thursday.
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#105216 (Remove unused GUI test) - rust-lang#105245 (attempt to clarify align_to docs) - rust-lang#105387 (Improve Rustdoc scrape-examples UI) - rust-lang#105389 (Enable profiler in dist-powerpc64le-linux) - rust-lang#105427 (Dont silently ignore rustdoc errors) - rust-lang#105442 (rustdoc: clean up docblock table CSS) - rust-lang#105443 (Move some queries and methods) - rust-lang#105455 (use the correct `Reveal` during validation) - rust-lang#105470 (Clippy: backport ICE fix before beta branch) - rust-lang#105474 (lib docs: fix typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth
Before beta is branched tomorrow we should backport the fix from rust-lang/rust-clippy#10027 for an ICE. That way we'll get this into stable one release sooner.
This only cherry-picks the fix, not the tests for it. The proper sync of this will be done next week Thursday.