Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard ProjectionTy creation against passing the wrong number of substs #105657

Merged
merged 12 commits into from
Dec 15, 2022
Merged

Guard ProjectionTy creation against passing the wrong number of substs #105657

merged 12 commits into from
Dec 15, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Dec 13, 2022

r? @lcnr

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 13, 2022

@bors try @rust-timer queue

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2022

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 13, 2022
@bors
Copy link
Contributor

bors commented Dec 13, 2022

⌛ Trying commit 717ee8c93aa8d2c0012c6a82cb808cd2f3438f54 with merge b805797cd260c2b99f6afb8a04b7ba6ca22283d5...

lcnr
lcnr reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nit + clean perf

compiler/rustc_middle/src/ty/context.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/ty/context.rs Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Dec 14, 2022

☔ The latest upstream changes (presumably #104986) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 14, 2022

@rust-timer build b805797cd260c2b99f6afb8a04b7ba6ca22283d5

@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 14, 2022

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Dec 14, 2022

⌛ Trying commit cbcf50c1cd276b2d89a901c12a13528d133592a3 with merge 5b56f9b4ca863174f9a9f913f29727f7736ab516...

@bors
Copy link
Contributor

bors commented Dec 14, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 14, 2022

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Dec 14, 2022

⌛ Trying commit 834cfdf37970f4fed1752819d16aeb8effc7a684 with merge 68ef7d9c99bd63c61581541647c642650988a3e0...

@bors
Copy link
Contributor

bors commented Dec 14, 2022

💔 Test failed - checks-actions

@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 14, 2022

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Dec 14, 2022

⌛ Trying commit b41a483 with merge f43b6fafd3cfac3a0a25ce97eab82fd294387627...

@bors
Copy link
Contributor

bors commented Dec 14, 2022

☀️ Try build successful - checks-actions
Build commit: f43b6fafd3cfac3a0a25ce97eab82fd294387627 (f43b6fafd3cfac3a0a25ce97eab82fd294387627)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f43b6fafd3cfac3a0a25ce97eab82fd294387627): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.6% [-0.7%, -0.4%] 3
Improvements ✅
(secondary)		 -0.7% [-0.7%, -0.6%] 9
All ❌✅ (primary) -0.6% [-0.7%, -0.4%] 3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.3% [3.0%, 3.5%] 2
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 -2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.2% [-2.8%, 3.5%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 14, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 14, 2022

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Dec 14, 2022

📌 Commit b41a483 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 14, 2022
@bors
Copy link
Contributor

bors commented Dec 15, 2022

⌛ Testing commit b41a483 with merge a8847df...

@bors
Copy link
Contributor

bors commented Dec 15, 2022

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing a8847df to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 15, 2022
@bors bors merged commit a8847df into rust-lang:master Dec 15, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 15, 2022
This was referenced Dec 15, 2022
Merged
Merged
Merged
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a8847df): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.0% [0.7%, 1.2%] 9
Improvements ✅
(primary)		 -0.4% [-0.6%, -0.1%] 2
Improvements ✅
(secondary)		 -0.7% [-0.7%, -0.5%] 8
All ❌✅ (primary) -0.4% [-0.6%, -0.1%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.1% [3.1%, 3.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot added the perf-regression Performance regression. label Dec 15, 2022
@oli-obk oli-obk deleted the mk_projection_ty branch December 15, 2022 09:00
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
celinval added a commit to celinval/kani-dev that referenced this pull request Jan 24, 2023
@celinval
Upgrade toolchain to nightly-2023-01-16
379413f 
This commit fixes compilation errors but not runtime ones. Related
changes:

rust-lang/rust#104986
rust-lang/rust#105657
rust-lang/rust#105603
rust-lang/rust#105613
@celinval celinval mentioned this pull request Jan 24, 2023
Merged
4 tasks
celinval added a commit to model-checking/kani that referenced this pull request Mar 8, 2023
@celinval
Upgrade toolchain to nightly-2023-01-23 (#2149)
5195423 
Upgrade our toolchain to `nightly-2023-01-23`. The changes here are related to the following changes:
- rust-lang/rust#104986
- rust-lang/rust#105657
- rust-lang/rust#105603
- rust-lang/rust#105613
- rust-lang/rust#105977
- rust-lang/rust#104645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@lcnr lcnr

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
7 participants
@oli-obk @rustbot @rust-timer @bors @rust-log-analyzer @compiler-errors @lcnr