Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow impl ~const Trait opaque types #105725

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Allow impl ~const Trait opaque types #105725

merged 2 commits into from
Dec 16, 2022

Conversation

fee1-dead
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2022

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 15, 2022
@fee1-dead
Copy link
Member Author

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned wesleywiser Dec 15, 2022
@fee1-dead fee1-dead force-pushed the allow-impl-const-trait branch from 3c7ab92 to 5da1a04 Compare December 15, 2022 11:27
@oli-obk
Copy link
Contributor

oli-obk commented Dec 15, 2022

r=me with tidy fixed

@onestacked
Copy link
Contributor

That is definitely a feature that cleans up a lot of const code!
Does this work with rpitit?
In either case its probably worth adding a test for that.

@fee1-dead fee1-dead force-pushed the allow-impl-const-trait branch from b6c5f6a to a8b9e00 Compare December 15, 2022 14:18
@fee1-dead
Copy link
Member Author

@bors r=oli-obk rollup

@bors
Copy link
Contributor

bors commented Dec 16, 2022

📌 Commit a8b9e00 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2022
@bors
Auto merge of rust-lang#105775 - matthiaskrgr:rollup-2o8qn7e, r=matth…
63b3bac 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105725 (Allow `impl ~const Trait` opaque types)
 - rust-lang#105744 (Rewrite `E0158` error-code docs for clarity)
 - rust-lang#105747 (Fix ICE calling method on auto trait)
 - rust-lang#105748 (doc: Fix a few small issues)
 - rust-lang#105756 (rustdoc: simplify CSS for codeblock tooltips)
 - rust-lang#105757 (rustdoc: remove unused CSS `.sub-settings`)
 - rust-lang#105764 (rustdoc: name the source page sidebar-toggle `#src-sidebar-toggle`)
 - rust-lang#105774 (Remove unused stderr files)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 22797ef into rust-lang:master Dec 16, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 16, 2022
@fee1-dead fee1-dead deleted the allow-impl-const-trait branch December 19, 2022 10:59
This was referenced Mar 16, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@fee1-dead @rustbot @oli-obk @onestacked @bors @wesleywiser