Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme: update section on how to run x.py #106146

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Readme: update section on how to run x.py #106146

merged 1 commit into from
Dec 27, 2022

Conversation

kadiwa4
Copy link
Contributor

@kadiwa4 kadiwa4 commented Dec 25, 2022 •
edited
Loading

./x.py currently looks for python3 (not python) in the PATH. I updated that in the readme and also mentioned a convenient way to run x.py on Windows. The PowerShell script is actually quite inconvenient to use (and not really necessary on the cmd.exe prompt) so I left it out.

In addition I adapted ./x in one of the CI scripts.

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 25, 2022
@Mark-Simulacrum
Copy link
Member

r? @jyn514

@rustbot rustbot assigned jyn514 and unassigned Mark-Simulacrum Dec 25, 2022
jyn514
jyn514 reviewed Dec 26, 2022
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PowerShell script is actually quite inconvenient to use (and not really unnecessary on the cmd.exe prompt) so I left it out

What do you mean by "inconvenient to use"? The whole point is for it to be convenient so if it doesn't work for you that's a bug we should fix :)

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2022
@kadiwa4
Copy link
Contributor Author

kadiwa4 commented Dec 26, 2022

By default, PowerShell will refuse to run any scripts. You need to manually change that. Also the script takes about 1 second to run which is really slow considering how small it is.

The python file can simply be executed directly (regardless of whether python3 exists in PATH) as long as .py files are configured to be opened with Python. To be honest I don't even know if it does that by default.

@jyn514
Copy link
Member

jyn514 commented Dec 26, 2022

Also the script takes about 1 second to run which is really slow considering how small it is.

hmm, that seems really strange, but I can replicate it locally. Don't know what could be taking any significant time :/

anyway, we don't need to fix it here.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 26, 2022

📌 Commit 9bf4036 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 26, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2022
@bors
Auto merge of rust-lang#106177 - matthiaskrgr:rollup-oe7z8ix, r=matth…
a1fc711 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#105515 (Account for macros in const generics)
 - rust-lang#106146 (Readme: update section on how to run `x.py`)
 - rust-lang#106150 (Detect when method call on LHS might be shadowed)
 - rust-lang#106174 (Remove unused empty CSS rules in ayu theme)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bb08f37 into rust-lang:master Dec 27, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 27, 2022
@atouchet atouchet mentioned this pull request Dec 29, 2022
Closed
@kadiwa4 kadiwa4 deleted the readme-x-py branch January 3, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kadiwa4 @rustbot @Mark-Simulacrum @jyn514 @bors