Revert "Implement allow-by-default multiple_supertrait_upcastable lint"
#106248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
dtolnay
removed
the
T-libs
bors
added
S-waiting-on-bors
|
Please add a regression test if reverting (fb61a2ce2b69fb7d16b3b85ac90890281f62f83a). |
|
@bors r=jackh726 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2022
…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#105903 (Unify id-based thread parking implementations) - rust-lang#106232 (CFI: Monomorphize transparent ADTs before typeid) - rust-lang#106248 (Revert "Implement allow-by-default `multiple_supertrait_upcastable` lint") - rust-lang#106286 (Make tidy errors red) - rust-lang#106295 (Extend scraped examples layout GUI test for position of buttons) - rust-lang#106305 ( bootstrap: Get rid of tail_args in stream_cargo) - rust-lang#106310 (Dont use `--merge-base` during bootstrap formatting subcommand) - rust-lang#106314 (Fix panic on `x build --help`) - rust-lang#106317 (Only deduplicate stack traces for good path bugs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean revert of #105484.
I confirmed that reverting that PR fixes the regression reported in #106247.
I can't say I understand what this code is doing, but maybe it can be re-landed with a different implementation.Edit: #106247 (comment) has an explanation of why #105484 ends up surfacing spuriouswhere_clause_object_safetyerrors. The implementation ofwhere_clause_object_safetyassumes we only check whether a trait is object safe when somebody actually uses that trait withdyn. However the implementation ofmultiple_supertrait_upcastableadded in the problematic PR involves checking every trait for whether it is object-safe.FYI @nbdd0121 @compiler-errors