Rollup of 9 pull requests #106256
Merged
Rollup of 9 pull requests #106256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo-miri: use rustc to determine the output filename This should fix rust-lang/miri#2740 and fix rust-lang/miri#1867: we no longer need to hard-code the file name logic in cargo-miri.
handle unknown targets more gracefully In particular don't require a list of all OSes in the TLS machinery. Instead just fall back to doing nothing.
simplify path joining code a bit
support using a JSON target file Fixes rust-lang/miri#2053
This doesn't have an effect, since these tooltip are only one line anyway.
The name makes a lot more sense, and `ty::TyKind` calls it `Ref` already as well.
CraftSpider was removed from the rustdoc team in rust-lang/team#897 and can no longer be assigned.
Partly address rust-lang#32059.
…n-err, r=estebank Make trait/impl `where` clause mismatch on region error a bit more actionable Improve `where` clause suggestions for GATs/methods that have incompatible region predicates in their `where` clauses. Also addresses this diagnostic that went away rust-lang#106129 (comment)
Powershell: Use `WaitForExit` instead of `-Wait` Using the method `WaitForExit` instead of the parameter `-Wait` results in a notable speed up of the `x.ps1` script (~350ms, fairly consistently). Results: ``` milliseconds before: 1127.7576 milliseconds after: 779.0467 ``` I think there are opportunities for further speed up by calling `Get-Command` only once with the pattern `py*` then filtering the returned list. But I'll leave that for another time (or someone else). r? ``@jyn514``
…, r=GuillaumeGomez
rustdoc: remove unnecessary `.tooltip::after { text-align: center }`
This doesn't have an effect, since these tooltip are only one line anyway.
…aped-examples, r=notriddle Migrate css var scraped examples r? ``@notriddle``
…lly, r=compiler-errors Rename `Rptr` to `Ref` in AST and HIR The name makes a lot more sense, and `ty::TyKind` calls it `Ref` already as well.
…compiler-errors On unsized locals with explicit types suggest `&` Fix rust-lang#72742.
Remove CraftSpider from review rotation CraftSpider was removed from the rustdoc team in rust-lang/team#897 and can no longer be assigned.
update Miri Main PRs: - rust-lang/miri#2741 - rust-lang/miri#2744 This should help quite a bit with Miri support for less common targets. :)
Detect diff markers in the parser Partly address rust-lang#32059.
rustbot
added
T-bootstrap
|
@bors r+ rollup=ever p=9 |
bors
added
S-waiting-on-bors
|
@bors r+ rollup=never p=9 |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 29d76cc6f5 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Dec 29, 2022
|
Finished benchmarking commit (e37ff7e): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#106208 (Make trait/impl `where` clause mismatch on region error a bit more actionable) - rust-lang#106216 (Powershell: Use `WaitForExit` instead of `-Wait`) - rust-lang#106217 (rustdoc: remove unnecessary `.tooltip::after { text-align: center }`) - rust-lang#106218 (Migrate css var scraped examples) - rust-lang#106221 (Rename `Rptr` to `Ref` in AST and HIR) - rust-lang#106223 (On unsized locals with explicit types suggest `&`) - rust-lang#106225 (Remove CraftSpider from review rotation) - rust-lang#106229 (update Miri) - rust-lang#106242 (Detect diff markers in the parser) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
whereclause mismatch on region error a bit more actionable #106208 (Make trait/implwhereclause mismatch on region error a bit more actionable)WaitForExitinstead of-Wait#106216 (Powershell: UseWaitForExitinstead of-Wait).tooltip::after { text-align: center }#106217 (rustdoc: remove unnecessary.tooltip::after { text-align: center })RptrtoRefin AST and HIR #106221 (RenameRptrtoRefin AST and HIR)𙻯 (On unsized locals with explicit types suggest&)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup