Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cc to 1.0.77 #106749

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Update cc to 1.0.77 #106749

merged 1 commit into from
Jan 22, 2023

Conversation

glandium
Copy link
Contributor

@glandium glandium commented Jan 12, 2023 •
edited by Mark-Simulacrum
Loading

Fixes (without a test) #98746.

@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

It would be good to add a test for this, I guess, so edited the description to avoid closing the issue for now (and labeled with E-needstest).

@bors
Copy link
Contributor

bors commented Jan 14, 2023

📌 Commit 820ffc8c171579adfa71b1b109ba0b7ebfe69b38 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
@bors
Copy link
Contributor

bors commented Jan 15, 2023

⌛ Testing commit 820ffc8c171579adfa71b1b109ba0b7ebfe69b38 with merge 941edd44cb510f207525783147b643b8a4c80e32...

@bors
Copy link
Contributor

bors commented Jan 15, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 15, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@glandium
Copy link
Contributor Author

I suspect the failure could be a side effect of rust-lang/cc-rs@0e51f6d . I'd suggest going with 1.0.77 for now, which only contains the wanted fix and the addition of the Build::asm_flag method, which wouldn't have side effects.

@glandium
Update cc to 1.0.77
b467547 
Fixes (without a test) rust-lang#98746.
@glandium glandium changed the title Update cc to 1.0.78 Update cc to 1.0.77 Jan 16, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2023

📌 Commit b467547 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2023
@compiler-errors compiler-errors mentioned this pull request Jan 22, 2023
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 22, 2023
@compiler-errors
Rollup merge of rust-lang#106749 - glandium:dwarf, r=Mark-Simulacrum
cfc1738 
Update cc to 1.0.77

Fixes (without a test) rust-lang#98746.
@compiler-errors compiler-errors mentioned this pull request Jan 22, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2023
@bors
Auto merge of rust-lang#107185 - compiler-errors:rollup-wkomjma, r=co…
940d00f 
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#103418 (Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report)
 - rust-lang#106113 (llvm-wrapper: adapt for LLVM API change)
 - rust-lang#106144 (Improve the documentation of `black_box`)
 - rust-lang#106578 (Label closure captures/generator locals that make opaque types recursive)
 - rust-lang#106749 (Update cc to 1.0.77)
 - rust-lang#106935 (Fix `SingleUseLifetime` ICE)
 - rust-lang#107015 (Re-enable building rust-analyzer on riscv64)
 - rust-lang#107029 (Add new bootstrap members to triagebot.toml)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5645d10 into rust-lang:master Jan 22, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 22, 2023
@ChrisDenton
Copy link
Member

@glandium is there an issue for the 1.0.78 breakage? I'd guess this is essentially caused by mixing llvm and msvc tools somewhere along the line?

@glandium
Copy link
Contributor Author

I didn't open an issue because it's not clear what's fault it is, and it's also not a problem unless you actively change the rustc tree. I figured the next person who upgrades cc will end up figuring it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@glandium @rustbot @Mark-Simulacrum @bors @rust-log-analyzer @ChrisDenton