Stabilize cmpxchg16b_target_feature #106774

Nugine · 2023-01-12T15:36:17Z

Tracking issue for target features

Tracking issue for RFC 2045: improving #[target_feature] #44839

stdarch issue

Stabilize cmpxchg16b stdarch#827

stdarch PR

Stabilize cmpxchg16b instrinsic stdarch#1358

reference PR

Document cmpxchg16b target feature reference#1331

It's my first time contributing to rust-lang/rust. Please tell me if I missed something.

rustbot · 2023-01-12T15:36:27Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon.

Please see the contribution instructions for more information.

rustbot · 2023-01-12T15:36:30Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

davidtwco

LGTM, but will hand-off to someone from t-libs to double-check.

davidtwco · 2023-01-25T13:32:59Z

r? @Amanieu

Amanieu · 2023-01-26T11:21:30Z

LGTM But I believe this needs T-lang signoff.

r? rust-lang/lang

bors · 2023-01-31T23:03:08Z

☔ The latest upstream changes (presumably #107297) made this pull request unmergeable. Please resolve the merge conflicts.

joshtriplett · 2023-02-07T19:17:17Z

@rfcbot merge

nikomatsakis · 2023-02-07T19:17:31Z

@rfcbot reviewed

joshtriplett · 2023-02-07T19:17:55Z

@rfcbot cancel

rfcbot · 2023-02-07T19:17:57Z

@joshtriplett proposal cancelled.

nikomatsakis · 2023-02-07T19:18:45Z

@rfcbot reviewed

rfcbot · 2023-02-07T19:19:13Z

🔔 This is now entering its final comment period, as per the review above. 🔔

ehuss · 2023-02-16T03:01:49Z

Can you send a PR to https://github.com/rust-lang/reference to update the list at https://github.com/rust-lang/reference/blob/master/src/attributes/codegen.md?plain=1#L77-L81 to include this new target feature?

Nugine · 2023-02-16T08:08:36Z

Can you send a PR to https://github.com/rust-lang/reference to update the list at https://github.com/rust-lang/reference/blob/master/src/attributes/codegen.md?plain=1#L77-L81 to include this new target feature?

Sure. Filed just now.

rfcbot · 2023-02-17T19:19:57Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

WaffleLapkin · 2023-02-24T12:12:34Z

The FCP is completed, can this be merged now?

Amanieu · 2023-02-27T15:29:09Z

@bors r+

bors · 2023-02-27T15:29:12Z

📌 Commit a4f2d14 has been approved by Amanieu

It is now in the queue for this repository.

bors · 2023-02-28T04:12:37Z

⌛ Testing commit a4f2d14 with merge fd1f1fa...

bors · 2023-02-28T07:09:04Z

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing fd1f1fa to master...

rust-timer · 2023-02-28T08:28:19Z

Finished benchmarking commit (fd1f1fa): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * Sadly, the patch to reduce the cargo verbosity no longer applies, so I've asked upstream about the proper way to get the old result. (so the build log becomes Quite Bloated for now). Upstream changes: Version 1.69.0 (2023-04-20) ========================== Language -------- - [Deriving built-in traits on packed structs works with `Copy` fields.] (rust-lang/rust#104429) - [Stabilize the `cmpxchg16b` target feature on x86 and x86_64.] (rust-lang/rust#106774) - [Improve analysis of trait bounds for associated types.] (rust-lang/rust#103695) - [Allow associated types to be used as union fields.] (rust-lang/rust#106938) - [Allow `Self: Autotrait` bounds on dyn-safe trait methods.] (rust-lang/rust#107082) - [Treat `str` as containing `[u8]` for auto trait purposes.] (rust-lang/rust#107941) Compiler -------- - [Upgrade `*-pc-windows-gnu` on CI to mingw-w64 v10 and GCC 12.2.] (rust-lang/rust#100178) - [Rework min_choice algorithm of member constraints.] (rust-lang/rust#105300) - [Support `true` and `false` as boolean flags in compiler arguments.] (rust-lang/rust#107043) - [Default `repr(C)` enums to `c_int` size.] (rust-lang/rust#107592) Libraries --------- - [Implement the unstable `DispatchFromDyn` for cell types, allowing downstream experimentation with custom method receivers.] (rust-lang/rust#97373) - [Document that `fmt::Arguments::as_str()` may return `Some(_)` in more cases after optimization, subject to change.] (rust-lang/rust#106823) - [Implement `AsFd` and `AsRawFd` for `Rc`.] (rust-lang/rust#107317) Stabilized APIs --------------- - [`CStr::from_bytes_until_nul`] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html#method.from_bytes_until_nul) - [`core::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesUntilNulError.html) These APIs are now stable in const contexts: - [`SocketAddr::new`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.new) - [`SocketAddr::ip`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.ip) - [`SocketAddr::port`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.port) - [`SocketAddr::is_ipv4`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv4) - [`SocketAddr::is_ipv6`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv6) - [`SocketAddrV4::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.new) - [`SocketAddrV4::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.ip) - [`SocketAddrV4::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.port) - [`SocketAddrV6::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.new) - [`SocketAddrV6::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.ip) - [`SocketAddrV6::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.port) - [`SocketAddrV6::flowinfo`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.flowinfo) - [`SocketAddrV6::scope_id`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.scope_id) Cargo ----- - [Cargo now suggests `cargo fix` or `cargo clippy --fix` when compilation warnings are auto-fixable.] (rust-lang/cargo#11558) - [Cargo now suggests `cargo add` if you try to install a library crate.] (rust-lang/cargo#11410) - [Cargo now sets the `CARGO_BIN_NAME` environment variable also for binary examples.] (rust-lang/cargo#11705) Rustdoc ----- - [Vertically compact trait bound formatting.] (rust-lang/rust#102842) - [Only include stable lints in `rustdoc::all` group.] (rust-lang/rust#106316) - [Compute maximum Levenshtein distance based on the query.] (rust-lang/rust#107141) - [Remove inconsistently-present sidebar tooltips.] (rust-lang/rust#107490) - [Search by macro when query ends with `!`.] (rust-lang/rust#108143) Compatibility Notes ------------------- - [The `rust-analysis` component from `rustup` now only contains a warning placeholder.] (rust-lang/rust#101841) This was primarily intended for RLS, and the corresponding `-Zsave-analysis` flag has been removed from the compiler as well. - [Unaligned references to packed fields are now a hard error.] (rust-lang/rust#102513) This has been a warning since 1.53, and denied by default with a future-compatibility warning since 1.62. - [Update the minimum external LLVM to 14.] (rust-lang/rust#107573) - [Cargo now emits errors on invalid characters in a registry token.] (rust-lang/cargo#11600) - [When `default-features` is set to false of a workspace dependency, and an inherited dependency of a member has `default-features = true`, Cargo will enable default features of that dependency.] (rust-lang/cargo#11409) - [Cargo denies `CARGO_HOME` in the `[env]` configuration table. Cargo itself doesn't pick up this value, but recursive calls to cargo would, which was not intended.] (rust-lang/cargo#11644) - [Debuginfo for build dependencies is now off if not explicitly set. This is expected to improve the overall build time.] (rust-lang/cargo#11252) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Move `format_args!()` into AST (and expand it during AST lowering)] (rust-lang/rust#106745)

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. Upstream changes: Version 1.69.0 (2023-04-20) ========================== Language -------- - [Deriving built-in traits on packed structs works with `Copy` fields.] (rust-lang/rust#104429) - [Stabilize the `cmpxchg16b` target feature on x86 and x86_64.] (rust-lang/rust#106774) - [Improve analysis of trait bounds for associated types.] (rust-lang/rust#103695) - [Allow associated types to be used as union fields.] (rust-lang/rust#106938) - [Allow `Self: Autotrait` bounds on dyn-safe trait methods.] (rust-lang/rust#107082) - [Treat `str` as containing `[u8]` for auto trait purposes.] (rust-lang/rust#107941) Compiler -------- - [Upgrade `*-pc-windows-gnu` on CI to mingw-w64 v10 and GCC 12.2.] (rust-lang/rust#100178) - [Rework min_choice algorithm of member constraints.] (rust-lang/rust#105300) - [Support `true` and `false` as boolean flags in compiler arguments.] (rust-lang/rust#107043) - [Default `repr(C)` enums to `c_int` size.] (rust-lang/rust#107592) Libraries --------- - [Implement the unstable `DispatchFromDyn` for cell types, allowing downstream experimentation with custom method receivers.] (rust-lang/rust#97373) - [Document that `fmt::Arguments::as_str()` may return `Some(_)` in more cases after optimization, subject to change.] (rust-lang/rust#106823) - [Implement `AsFd` and `AsRawFd` for `Rc`.] (rust-lang/rust#107317) Stabilized APIs --------------- - [`CStr::from_bytes_until_nul`] (https://doc.rust-lang.org/stable/core/ffi/struct.CStr.html#method.from_bytes_until_nul) - [`core::ffi::FromBytesUntilNulError`] (https://doc.rust-lang.org/stable/core/ffi/struct.FromBytesUntilNulError.html) These APIs are now stable in const contexts: - [`SocketAddr::new`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.new) - [`SocketAddr::ip`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.ip) - [`SocketAddr::port`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.port) - [`SocketAddr::is_ipv4`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv4) - [`SocketAddr::is_ipv6`] (https://doc.rust-lang.org/stable/std/net/enum.SocketAddr.html#method.is_ipv6) - [`SocketAddrV4::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.new) - [`SocketAddrV4::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.ip) - [`SocketAddrV4::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV4.html#method.port) - [`SocketAddrV6::new`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.new) - [`SocketAddrV6::ip`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.ip) - [`SocketAddrV6::port`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.port) - [`SocketAddrV6::flowinfo`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.flowinfo) - [`SocketAddrV6::scope_id`] (https://doc.rust-lang.org/stable/std/net/struct.SocketAddrV6.html#method.scope_id) Cargo ----- - [Cargo now suggests `cargo fix` or `cargo clippy --fix` when compilation warnings are auto-fixable.] (rust-lang/cargo#11558) - [Cargo now suggests `cargo add` if you try to install a library crate.] (rust-lang/cargo#11410) - [Cargo now sets the `CARGO_BIN_NAME` environment variable also for binary examples.] (rust-lang/cargo#11705) Rustdoc ----- - [Vertically compact trait bound formatting.] (rust-lang/rust#102842) - [Only include stable lints in `rustdoc::all` group.] (rust-lang/rust#106316) - [Compute maximum Levenshtein distance based on the query.] (rust-lang/rust#107141) - [Remove inconsistently-present sidebar tooltips.] (rust-lang/rust#107490) - [Search by macro when query ends with `!`.] (rust-lang/rust#108143) Compatibility Notes ------------------- - [The `rust-analysis` component from `rustup` now only contains a warning placeholder.] (rust-lang/rust#101841) This was primarily intended for RLS, and the corresponding `-Zsave-analysis` flag has been removed from the compiler as well. - [Unaligned references to packed fields are now a hard error.] (rust-lang/rust#102513) This has been a warning since 1.53, and denied by default with a future-compatibility warning since 1.62. - [Update the minimum external LLVM to 14.] (rust-lang/rust#107573) - [Cargo now emits errors on invalid characters in a registry token.] (rust-lang/cargo#11600) - [When `default-features` is set to false of a workspace dependency, and an inherited dependency of a member has `default-features = true`, Cargo will enable default features of that dependency.] (rust-lang/cargo#11409) - [Cargo denies `CARGO_HOME` in the `[env]` configuration table. Cargo itself doesn't pick up this value, but recursive calls to cargo would, which was not intended.] (rust-lang/cargo#11644) - [Debuginfo for build dependencies is now off if not explicitly set. This is expected to improve the overall build time.] (rust-lang/cargo#11252) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Move `format_args!()` into AST (and expand it during AST lowering)] (rust-lang/rust#106745)

rustbot assigned davidtwco Jan 12, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 12, 2023

davidtwco approved these changes Jan 25, 2023

View reviewed changes

rustbot assigned Amanieu and unassigned davidtwco Jan 25, 2023

rustbot assigned tmandry and unassigned Amanieu Jan 26, 2023

Stabilize cmpxchg16b_target_feature

a4f2d14

Nugine closed this Feb 1, 2023

Nugine force-pushed the master branch from 0ece6cf to 5b6ed25 Compare February 1, 2023 02:55

Nugine reopened this Feb 1, 2023

tmandry added the I-lang-nominated Nominated for discussion during a lang team meeting. label Feb 3, 2023

This comment was marked as outdated.

Sign in to view

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Feb 7, 2023

joshtriplett removed the I-lang-nominated Nominated for discussion during a lang team meeting. label Feb 7, 2023

rfcbot removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Feb 7, 2023

joshtriplett removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 7, 2023

rfcbot added the disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. label Feb 7, 2023

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 7, 2023

joshtriplett added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 7, 2023

Nugine mentioned this pull request Feb 16, 2023

Document cmpxchg16b target feature rust-lang/reference#1331

Merged

apiraino removed the to-announce Announce this issue on triage meeting label Feb 24, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 28, 2023

bors merged commit fd1f1fa into rust-lang:master Feb 28, 2023

rustbot added this to the 1.69.0 milestone Feb 28, 2023

bors mentioned this pull request Feb 28, 2023

Stabilize movbe target feature #107711

Merged

taiki-e mentioned this pull request Feb 28, 2023

x86_64: Update to stabilized cmpxchg16b_target_feature taiki-e/portable-atomic#80

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize cmpxchg16b_target_feature #106774

Stabilize cmpxchg16b_target_feature #106774

Nugine commented Jan 12, 2023 •

edited

Loading

rustbot commented Jan 12, 2023

rustbot commented Jan 12, 2023

davidtwco left a comment

davidtwco commented Jan 25, 2023

Amanieu commented Jan 26, 2023

bors commented Jan 31, 2023

joshtriplett commented Feb 7, 2023

This comment was marked as outdated.

nikomatsakis commented Feb 7, 2023

joshtriplett commented Feb 7, 2023

rfcbot commented Feb 7, 2023

nikomatsakis commented Feb 7, 2023

rfcbot commented Feb 7, 2023

ehuss commented Feb 16, 2023

Nugine commented Feb 16, 2023

rfcbot commented Feb 17, 2023

WaffleLapkin commented Feb 24, 2023

Amanieu commented Feb 27, 2023

bors commented Feb 27, 2023

bors commented Feb 28, 2023

bors commented Feb 28, 2023

rust-timer commented Feb 28, 2023

Stabilize cmpxchg16b_target_feature #106774

Stabilize cmpxchg16b_target_feature #106774

Conversation

Nugine commented Jan 12, 2023 • edited Loading

rustbot commented Jan 12, 2023

rustbot commented Jan 12, 2023

davidtwco left a comment

Choose a reason for hiding this comment

davidtwco commented Jan 25, 2023

Amanieu commented Jan 26, 2023

bors commented Jan 31, 2023

joshtriplett commented Feb 7, 2023

This comment was marked as outdated.

nikomatsakis commented Feb 7, 2023

joshtriplett commented Feb 7, 2023

rfcbot commented Feb 7, 2023

nikomatsakis commented Feb 7, 2023

rfcbot commented Feb 7, 2023

ehuss commented Feb 16, 2023

Nugine commented Feb 16, 2023

rfcbot commented Feb 17, 2023

WaffleLapkin commented Feb 24, 2023

Amanieu commented Feb 27, 2023

bors commented Feb 27, 2023

bors commented Feb 28, 2023

bors commented Feb 28, 2023

rust-timer commented Feb 28, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Nugine commented Jan 12, 2023 •

edited

Loading