-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store metrics from metrics.json
to CI PGO timer
#107733
Conversation
@bors try |
⌛ Trying commit 533f368a4a249b4d633523138d191a7071255093 with merge 5da6158be72dc13b1d22ab9b26314934c006606c... |
☀️ Try build successful - checks-actions |
@bors try |
⌛ Trying commit 508e09054a83b6b91f6a4851d5fb72ba01c2ff2a with merge e2cfad8a2d202916fcb725b89988bb10d1ff13e7... |
☀️ Try build successful - checks-actions |
1 similar comment
☀️ Try build successful - checks-actions |
508e090
to
dc25aba
Compare
@bors try |
⌛ Trying commit dc25abab8fe0e97ae516498cdccf9d41e939b693 with merge 05450d2fadee98bbacea208d4fec9338d5306134... |
This is how the output currently looks like:
Some notes:
@rustbot ready |
☀️ Try build successful - checks-actions |
@bors try |
⌛ Trying commit 405ae93b3c65f5eb8aeff9f3031d625216f2e32d with merge 673cf0b55804c7f35afa1fe06ac1e171a40021af... |
☀️ Try build successful - checks-actions |
405ae93
to
6864750
Compare
@bors try |
⌛ Trying commit 68647501a87537dd11b4005907e1a18c7f20332f with merge a57fd671624190eee8b3ef0bab0e966e141b1e42... |
☀️ Try build successful - checks-actions |
Ok, now we have a nicely formatted output of the individual build steps duration in the log. There's no one single "bottleneck" in the dist build, it just takes time to build Clippy, Rust analyzer, Cargo, docs etc. |
This comment has been minimized.
This comment has been minimized.
r=me with nit fixed |
478676b
to
dd7c968
Compare
Added an assertion that at least one LLVM/rustc build step was found. |
Co-authored-by: Jakub Beránek <[email protected]>
dd7c968
to
afe9553
Compare
@bors try (just to make sure that nothing broke after I rebased on |
⌛ Trying commit afe9553 with merge 86befc5b181576165e2498d800391fa3efde56c5... |
☀️ Try build successful - checks-actions |
1 similar comment
☀️ Try build successful - checks-actions |
Looks good. @Mark-Simulacrum should be ready for merging. |
@bors r+ |
…imulacrum Store metrics from `metrics.json` to CI PGO timer With this change, we'll be able to easily see how long does it take to compile LLVM vs `rustc`. r? `@Mark-Simulacrum`
…imulacrum Store metrics from `metrics.json` to CI PGO timer With this change, we'll be able to easily see how long does it take to compile LLVM vs `rustc`. r? ``@Mark-Simulacrum``
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#107573 (Update the minimum external LLVM to 14) - rust-lang#107626 (Fix `x fix` on the standard library itself) - rust-lang#107673 (update ICU4X to 1.1.0) - rust-lang#107733 (Store metrics from `metrics.json` to CI PGO timer) - rust-lang#108007 (Use `is_str` instead of string kind comparison) - rust-lang#108033 (add an unstable `#[rustc_coinductive]` attribute) - rust-lang#108039 (Refactor refcounted structural_impls via functors) - rust-lang#108040 (Use derive attributes for uninteresting traversals) - rust-lang#108044 (interpret: rename Pointer::from_addr → from_addr_invalid) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#107573 (Update the minimum external LLVM to 14) - rust-lang#107626 (Fix `x fix` on the standard library itself) - rust-lang#107673 (update ICU4X to 1.1.0) - rust-lang#107733 (Store metrics from `metrics.json` to CI PGO timer) - rust-lang#108007 (Use `is_str` instead of string kind comparison) - rust-lang#108033 (add an unstable `#[rustc_coinductive]` attribute) - rust-lang#108039 (Refactor refcounted structural_impls via functors) - rust-lang#108040 (Use derive attributes for uninteresting traversals) - rust-lang#108044 (interpret: rename Pointer::from_addr → from_addr_invalid) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
With this change, we'll be able to easily see how long does it take to compile LLVM vs
rustc
.r? @Mark-Simulacrum