Make derive_const derive properly const-if-const impls
#107777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
Feb 7, 2023
| @@ -154,7 +154,7 @@ fn mk_ty_param( | |||
| .iter() | |||
| .map(|b| { | |||
| let path = b.to_path(cx, span, self_ident, self_generics); | |||
| cx.trait_bound(path) | |||
| cx.trait_bound(path, false) | |||
There was a problem hiding this comment.
This prevents us from generating methods with const bounds on their parameters, but none of the built-in impls actually use type parameters on their methods, so I didn't really want to thread a boolean down 3 levels to this call site.
|
@bors r+ |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 8, 2023
…lly-derive-const, r=fee1-dead Make `derive_const` derive properly const-if-const impls Fixes rust-lang#107774 Fixes rust-lang#107666 Also fixes rendering of const-if-const bounds in pretty printing. r? `@oli-obk` or `@fee1-dead`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 8, 2023
…lly-derive-const, r=fee1-dead Make `derive_const` derive properly const-if-const impls Fixes rust-lang#107774 Fixes rust-lang#107666 Also fixes rendering of const-if-const bounds in pretty printing. r? ``@oli-obk`` or ``@fee1-dead``
This was referenced Feb 8, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#105641 (Implement cursors for BTreeMap) - rust-lang#107271 (Treat Drop as a rmw operation) - rust-lang#107710 (Update strip-ansi-escapes and vte) - rust-lang#107758 (Change `arena_cache` to not alter the declared query result) - rust-lang#107777 (Make `derive_const` derive properly const-if-const impls) - rust-lang#107780 (Rename `replace_bound_vars_with_*` to `instantiate_binder_with_*`) - rust-lang#107793 (Add missing tracking issue for `RawOsError`) - rust-lang#107807 (Fix small debug typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107774
Fixes #107666
Also fixes rendering of const-if-const bounds in pretty printing.
r? @oli-obk or @fee1-dead