Rollup of 8 pull requests #107788
Merged
Rollup of 8 pull requests #107788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes generation of `manifest.in` deterministic: rust-lang/rust-installer#120
Since these elements now use `white-space: pre-wrap` since 784665d, it's fine to use newlines for formatting, which is smaller and a bit less complicated.
Modify main message to be more conversational and emit one fewer note.
…-Simulacrum Bump rust-installer Makes generation of `manifest.in` deterministic: rust-lang/rust-installer#120
…yn514 Allow automatically creating vscode `settings.json` with `x setup` Closes rust-lang#107703
Rename `PointerSized` to `PointerLike`
The old name was unnecessarily vague. This PR renames a nightly language feature that I added, so I don't think it needs any additional approval, though anyone can feel free to speak up if you dislike the rename.
It's still unsatisfying that we don't the user which of {size, alignment} is wrong, but this trait really is just a stepping stone for a more generalized mechanism to create `dyn*`, just meant for nightly testing, so I don't think it really deserves additional diagnostic machinery for now.
Fixes rust-lang#107696, cc ``@RalfJung``
r? ``@eholk``
…aumeGomez rustdoc: use a newline instead of `<br>` to format code headers Since these elements now use `white-space: pre-wrap` since rust-lang#107615, it's fine to use newlines for formatting, which is smaller and a bit less complicated.
Tweak ICE message Modify main message to be more conversational and emit one fewer note.
…te, r=estebank Clearly signal purpose of the yaml template Following up on rust-lang#106898 (comment)
…, r=cuviper Docs: Fix format of headings in String::reserve It was inconsistent with other doc comments in the same module (and the rest of the rust std docs).
…ckh726 Remove astconv usage in diagnostic Fixes rust-lang#107775 Location of the test sucks, I know, but I needed to put it somewhere 😓 The issue here is that the root cause of the issue has nothing to do with what's being tested, so I couldn't really give it a better name. Oh well.
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 7ba4e95368 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (6eb9f2d): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
settings.jsonwithx setup#107757 (Allow automatically creating vscodesettings.jsonwithx setup)PointerSizedtoPointerLike#107769 (RenamePointerSizedtoPointerLike)<br>to format code headers #107770 (rustdoc: use a newline instead of<br>to format code headers)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup