-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure test_type_match
doesn't ICE with late-bound types
#108202
Merged
bors
merged 1 commit into
rust-lang:master
from
compiler-errors:non_lifetime_binders-type-match-ice
Feb 22, 2023
Merged
Make sure test_type_match
doesn't ICE with late-bound types
#108202
bors
merged 1 commit into
rust-lang:master
from
compiler-errors:non_lifetime_binders-type-match-ice
Feb 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 18, 2023
compiler-errors
changed the title
Make sure test_type_match doesn't ICE with late-bound types
Make sure Feb 18, 2023
test_type_match
doesn't ICE with late-bound types
compiler-errors
force-pushed
the
non_lifetime_binders-type-match-ice
branch
from
February 18, 2023 04:41
f6108ac
to
454f5f8
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
non_lifetime_binders-type-match-ice
branch
from
February 18, 2023 19:51
454f5f8
to
5926b54
Compare
compiler-errors
force-pushed
the
non_lifetime_binders-type-match-ice
branch
from
February 18, 2023 20:17
5926b54
to
c13d5f1
Compare
davidtwco
approved these changes
Feb 21, 2023
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 21, 2023
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 21, 2023
…rs-type-match-ice, r=davidtwco Make sure `test_type_match` doesn't ICE with late-bound types Fixes rust-lang#108190 (in a kind of hacky way, anyways doesn't really matter)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#104239 (Better debug logs for borrowck constraint graph) - rust-lang#108202 (Make sure `test_type_match` doesn't ICE with late-bound types) - rust-lang#108295 (Use DefKind to give more item kind information during BindingObligation note ) - rust-lang#108306 (compiletest: up deps) - rust-lang#108313 (Fix compiletest possible crash in option only-modified) - rust-lang#108322 (Clean ConstProp) - rust-lang#108323 (hir-analysis: make one diagnostic translatable) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
added
the
F-non_lifetime_binders
`#![feature(non_lifetime_binders)]`
label
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
F-non_lifetime_binders
`#![feature(non_lifetime_binders)]`
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108190 (in a kind of hacky way, anyways doesn't really matter)