Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure test_type_match doesn't ICE with late-bound types #108202

Merged

Conversation

compiler-errors
Copy link
Member

Fixes #108190 (in a kind of hacky way, anyways doesn't really matter)

@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 18, 2023
@compiler-errors compiler-errors changed the title Make sure test_type_match doesn't ICE with late-bound types Make sure test_type_match doesn't ICE with late-bound types Feb 18, 2023
@compiler-errors compiler-errors force-pushed the non_lifetime_binders-type-match-ice branch from f6108ac to 454f5f8 Compare February 18, 2023 04:41
@rust-log-analyzer

This comment has been minimized.

@compiler-errors compiler-errors force-pushed the non_lifetime_binders-type-match-ice branch from 454f5f8 to 5926b54 Compare February 18, 2023 19:51
@compiler-errors compiler-errors force-pushed the non_lifetime_binders-type-match-ice branch from 5926b54 to c13d5f1 Compare February 18, 2023 20:17
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 21, 2023

📌 Commit c13d5f1 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Feb 21, 2023
…rs-type-match-ice, r=davidtwco

Make sure `test_type_match` doesn't ICE with late-bound types

Fixes rust-lang#108190 (in a kind of hacky way, anyways doesn't really matter)
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 22, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#104239 (Better debug logs for borrowck constraint graph)
 - rust-lang#108202 (Make sure `test_type_match` doesn't ICE with late-bound types)
 - rust-lang#108295 (Use DefKind to give more item kind information during BindingObligation note )
 - rust-lang#108306 (compiletest: up deps)
 - rust-lang#108313 (Fix compiletest possible crash in option only-modified)
 - rust-lang#108322 (Clean ConstProp)
 - rust-lang#108323 (hir-analysis: make one diagnostic translatable)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8a5843f into rust-lang:master Feb 22, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 22, 2023
@compiler-errors compiler-errors added the F-non_lifetime_binders `#![feature(non_lifetime_binders)]` label Mar 10, 2023
@compiler-errors compiler-errors deleted the non_lifetime_binders-type-match-ice branch August 11, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-non_lifetime_binders `#![feature(non_lifetime_binders)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: bound types encountered in super_relate_tys non_lifetime_binders
5 participants