apply query response: actually define opaque types #108342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ Ah that explains it. We used to not run the infer var replacement for TAITs, so it worked before. But once I flipped the default to "not infer opaque types", this "regressed". I do wonder why we use the evaluate queries so little in typeck, but apparently do so for the return type @bors r+ rollup |
bors
added
S-waiting-on-bors
|
💡 This pull request was already approved, no need to approve it again.
|
we only do it during mir typeck, hir typeck never uses canonical queries atm. I expect that by using the inference var replacement for opaques in the return type and so on, we tend to not have opaque types in the types of locals or sth 🤔 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#107736 ( Rename atomic 'as_mut_ptr' to 'as_ptr' to match Cell (ref rust-lang#66893) ) - rust-lang#108176 (Don't delay `ReError` bug during lexical region resolve) - rust-lang#108315 (Lint dead code in closures and generators) - rust-lang#108342 (apply query response: actually define opaque types) - rust-lang#108344 (Fix test filename for rust-lang#105700) - rust-lang#108353 (resolve: Remove `ImportResolver`) Failed merges: - rust-lang#107911 (Add check for invalid #[macro_export] arguments) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure whether this fixes any code considering that #107891 doesn't break anything, but this is currently wrong as the
eqthere should just always fail right now.We can definitely hit this code if we remove the
replace_opaque_types_with_inference_varshack. Doing so without this PR causes a few tests to ICE, e.g.rust/tests/ui/impl-trait/issue-99642.rs
Lines 1 to 7 in bd4a96a
r? @oli-obk