Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent overflow through Arc::downgrade #108708

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Prevent overflow through Arc::downgrade #108708

merged 1 commit into from
Mar 11, 2023

Conversation

noamtashma
Copy link
Contributor

@noamtashma noamtashma commented Mar 3, 2023 •
edited by m-ou-se
Loading

Fixes #108706

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 3, 2023
@rustbot

This comment was marked as resolved.

Sign in to view
@noamtashma noamtashma mentioned this pull request Mar 3, 2023
Closed
Noratrieb
Noratrieb reviewed Mar 3, 2023
View reviewed changes
library/alloc/src/sync.rs Outdated Show resolved Hide resolved
m-ou-se
m-ou-se reviewed Mar 3, 2023
View reviewed changes
library/alloc/src/sync.rs Outdated Show resolved Hide resolved
@m-ou-se m-ou-se changed the title issue-108706-fix Prevent overflow through Arc::downgrade Mar 3, 2023
@m-ou-se m-ou-se assigned m-ou-se and unassigned Mark-Simulacrum Mar 3, 2023
@noamtashma noamtashma requested a review from m-ou-se March 4, 2023 18:21
m-ou-se
m-ou-se approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@m-ou-se m-ou-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for the quick fix!

Can you squash the commits into one?

@noamtashma
Copy link
Contributor Author

@m-ou-se , What should be done now?

@m-ou-se
Copy link
Member

m-ou-se commented Mar 10, 2023

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 10, 2023

📌 Commit 620544e has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#108708 - noamtashma:issue-108706-fix, r=m-o…
823174f 
…u-se

Prevent overflow through Arc::downgrade

Fixes rust-lang#108706
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 11, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 11, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2023
@bors
Auto merge of rust-lang#109019 - matthiaskrgr:rollup-ihjntil, r=matth…
8a73f50 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104363 (Make `unused_allocation` lint against `Box::new` too)
 - rust-lang#106633 (Stabilize `nonzero_min_max`)
 - rust-lang#106844 (allow negative numeric literals in `concat!`)
 - rust-lang#108071 (Implement goal caching with the new solver)
 - rust-lang#108542 (Force parentheses around `match` expression in binary expression)
 - rust-lang#108690 (Place size limits on query keys and values)
 - rust-lang#108708 (Prevent overflow through Arc::downgrade)
 - rust-lang#108739 (Prevent the `start_bx` basic block in codegen from having two `Builder`s at the same time)
 - rust-lang#108806 (Querify register_tools and post-expansion early lints)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5adaa71 into rust-lang:master Mar 11, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb left review comments

@workingjubilee workingjubilee workingjubilee left review comments

@m-ou-se m-ou-se m-ou-se approved these changes

Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

Overflow in Arc
7 participants
@noamtashma @rustbot @m-ou-se @bors @workingjubilee @Noratrieb @Mark-Simulacrum