Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DropAndReplace terminator #108856

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Remove DropAndReplace terminator #108856

merged 2 commits into from
Mar 9, 2023

Conversation

zeegomo
Copy link
Contributor

@zeegomo zeegomo commented Mar 7, 2023

#107844 made DropAndReplace unused, let's remove it completely from the codebase.

@rustbot
Copy link
Collaborator

rustbot commented Mar 7, 2023

r? @Nilstrieb

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 7, 2023
@zeegomo
Remove DropAndReplace terminator
c5d4e4d 
PR 107844 made DropAndReplace unused, let's remove it completely
from the codebase.
@zeegomo zeegomo force-pushed the remove-drop-and-rep branch from 1c8b795 to c5d4e4d Compare March 7, 2023 13:25
@rustbot
Copy link
Collaborator

rustbot commented Mar 7, 2023

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

tmiasko
tmiasko approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@tmiasko tmiasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! r=me with outdated comment removed.

compiler/rustc_const_eval/src/transform/check_consts/resolver.rs Show resolved Hide resolved
@tmiasko
Copy link
Contributor

tmiasko commented Mar 7, 2023

@bors delegate=Zeegomo

@bors
Copy link
Contributor

bors commented Mar 7, 2023

✌️ @zeegomo can now approve this pull request

@Noratrieb Noratrieb assigned tmiasko and unassigned Noratrieb Mar 7, 2023
@tmiasko
Copy link
Contributor

tmiasko commented Mar 7, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 7, 2023

📌 Commit 153bfa0 has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2023
@JohnTitor JohnTitor mentioned this pull request Mar 8, 2023
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 8, 2023
@JohnTitor
Rollup merge of rust-lang#108856 - Zeegomo:remove-drop-and-rep, r=tmi…
645bed4 
…asko

Remove DropAndReplace terminator

rust-lang#107844 made DropAndReplace unused, let's remove it completely from the codebase.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 8, 2023
@JohnTitor
Rollup merge of rust-lang#108856 - Zeegomo:remove-drop-and-rep, r=tmi…
3c9b079 
…asko

Remove DropAndReplace terminator

rust-lang#107844 made DropAndReplace unused, let's remove it completely from the codebase.
@JohnTitor JohnTitor mentioned this pull request Mar 8, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 8, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2023
@bors
Auto merge of rust-lang#108920 - matthiaskrgr:rollup-qrr9a0u, r=matth…
39f2657 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#108754 (Retry `pred_known_to_hold_modulo_regions` with fulfillment if ambiguous)
 - rust-lang#108759 (1.41.1 supported 32-bit Apple targets)
 - rust-lang#108839 (Canonicalize root var when making response from new solver)
 - rust-lang#108856 (Remove DropAndReplace terminator)
 - rust-lang#108882 (Tweak E0740)
 - rust-lang#108898 (Set `LIBC_CHECK_CFG=1` when building Rust code in bootstrap)
 - rust-lang#108911 (Improve rustdoc-gui/tester.js code a bit)
 - rust-lang#108916 (Remove an unused return value in `rustc_hir_typeck`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4e84fbf into rust-lang:master Mar 9, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 9, 2023
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#108856 - Zeegomo:remove-drop-and-rep, r=tmi…
d9fdac5 
…asko

Remove DropAndReplace terminator

rust-lang#107844 made DropAndReplace unused, let's remove it completely from the codebase.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 10, 2023
@bors
Auto merge of rust-lang#108920 - matthiaskrgr:rollup-qrr9a0u, r=matth…
eceedd9 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#108754 (Retry `pred_known_to_hold_modulo_regions` with fulfillment if ambiguous)
 - rust-lang#108759 (1.41.1 supported 32-bit Apple targets)
 - rust-lang#108839 (Canonicalize root var when making response from new solver)
 - rust-lang#108856 (Remove DropAndReplace terminator)
 - rust-lang#108882 (Tweak E0740)
 - rust-lang#108898 (Set `LIBC_CHECK_CFG=1` when building Rust code in bootstrap)
 - rust-lang#108911 (Improve rustdoc-gui/tester.js code a bit)
 - rust-lang#108916 (Remove an unused return value in `rustc_hir_typeck`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Mar 15, 2023
@matthiaskrgr
Rollup merge of rust-lang#108856 - Zeegomo:remove-drop-and-rep, r=tmi…
2ad8e1f 
…asko

Remove DropAndReplace terminator

rust-lang#107844 made DropAndReplace unused, let's remove it completely from the codebase.
@celinval celinval mentioned this pull request Apr 26, 2023
Merged
4 tasks
celinval added a commit to model-checking/kani that referenced this pull request May 16, 2023
@celinval
Upgrade the toolchain to nightly-2023-04-16 (#2406)
6f7aa65 
Update the toolchain to use nightly-2023-04-16. Changes were related to the following changes to the toolchain:

- rust-lang/rust#108944
- rust-lang/rust#108148
- rust-lang/rust#108471
- rust-lang/rust#109358
- rust-lang/rust#109849
- rust-lang/rust#109819
- rust-lang/rust#109718
- rust-lang/rust#109092
- rust-lang/rust#108856
- rust-lang/rust#105613
- rust-lang/rust#103042
- rust-lang/rust#109716
- rust-lang/rust#108340
- rust-lang/rust#102906
- rust-lang/rust#98112
- rust-lang/rust#108080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmiasko tmiasko tmiasko approved these changes

Assignees

@tmiasko tmiasko

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeegomo @rustbot @tmiasko @bors @Noratrieb