Move doc(primitive) future incompat warning to invalid_doc_attributes

[GuillaumeGomez]

Fixes #88070.

It's been a while since this was turned into a "future incompatible lint" so I think we can now turn it into a hard error without problem.

r? @jyn514

[jyn514]

Can you make this part of the rustc_attrs feature gate so we don't have to maintain a separate error message and feature gate?

[GuillaumeGomez]

Good idea!

[rustbot]

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[GuillaumeGomez]

To make it work, I needed to update how it's handled in rustdoc and to put it behind a cfg in the std.

[bors]

☔ The latest upstream changes (presumably #109503) made this pull request unmergeable. Please resolve the merge conflicts.

[GuillaumeGomez]

Rebased.

[jyn514]

I don't have time for reviews right now.

r? rustdoc cc @petrochenkov

[GuillaumeGomez]

cc @petrochenkov since they worked on something similar in #109534.

[GuillaumeGomez]

r? @notriddle

[rustbot]

Could not assign reviewer from: notriddle.
User(s) notriddle are either the PR author or are already assigned, and there are no other candidates.
Use r? to specify someone else to assign.

[bors]

☔ The latest upstream changes (presumably #109769) made this pull request unmergeable. Please resolve the merge conflicts.

[notriddle]

let as_primitive = |res: Res<!>| {
    let Res::Def(DefKind::Mod, def_id) = res else { return None };
    tcx.get_attrs(def_id, sym::rustc_doc_primitive).find_map(|attr| {
        Some((def_id, PrimitiveType::from_symbol(attr.value_str()?)?))
    })
};

[GuillaumeGomez]

It's much better, thanks!

[notriddle]

@bors r+

[bors]

📌 Commit 7167054be4f13814e6ea0d6d2735174eaf2e3f4d has been approved by notriddle

It is now in the queue for this repository.

[notriddle]

@bors r-

Broken intra-doc links.

[jyn514]

Shouldn't we do a crater run for this change?

[notriddle]

I wasn't planning to, since

• None came up last time: Add future-incompat lint for doc(primitive) #87050 (comment)
• This changes what the lint says, but it's actually still a lint and will be subject to the --cap-lints if it triggers on a transitive dependency, as can be seen in https://github.com/rust-lang/rust/pull/109443/files#diff-e6bbd09387e71c4a8a9ebb4a95099ca4ac8f4ea5f04f59a6ef6e0586e866c8d1

[jyn514]

Ok, please update the PR description to reflect what the PR now does.

[GuillaumeGomez]

@jyn514 Considering we have a warning that have been around for quite a while, I think it's ok. But do you see a reason where it could a be a problem maybe?

EDIT: sorry, the page wasn't updated. notriddle already answered. :)

[GuillaumeGomez]

Found the problem: since some parts of intra-doc link generation was moved into rustc_resolve, it used doc(primitive) in there too but wasn't updated.

[GuillaumeGomez]

@bors r=notriddle

[bors]

📌 Commit f6035fb has been approved by notriddle

It is now in the queue for this repository.