Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit to one link job on mingw builders #109643

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Mar 26, 2023

This is another attempt to work around
#108227.

By limiting to one link job, we should be able to avoid file name clashes in mkstemp().

This is another attempt to work around
rust-lang#108227.

By limiting to one link job, we should be able to avoid file name
clashes in mkstemp().
@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2023

r? @pietroalbini

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 26, 2023
@pietroalbini
Copy link
Member

@bors r+ p=100

@bors
Copy link
Contributor

bors commented Mar 26, 2023

📌 Commit dd7db8b has been approved by pietroalbini

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 26, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2023
@bors
Copy link
Contributor

bors commented Mar 26, 2023

⌛ Testing commit dd7db8b with merge 1d58207...

@bors
Copy link
Contributor

bors commented Mar 27, 2023

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 1d58207 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 27, 2023
@bors bors merged commit 1d58207 into rust-lang:master Mar 27, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 27, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d58207): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.4% [-2.1%, -0.4%] 20
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.4% [-2.1%, -0.4%] 20

Cycles

This benchmark run did not return any relevant results for this metric.

@ehuss
Copy link
Contributor

ehuss commented Apr 12, 2023

@pietroalbini I might suggest backporting this to beta to reduce the trouble with trying to land PRs.

@ehuss ehuss added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 14, 2023
@pietroalbini pietroalbini added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 16, 2023
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 16, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2023
…troalbini

[stable] Prepare Rust 1.69.0

Last minute backports:

*  rust-lang#109643
* rust-lang#110135
* rust-lang#109938
* rust-lang#109937
* rust-lang#109266

This PR also bumps the channel to stable, and backports the release notes from master.

r? `@ghost`
cc `@rust-lang/release`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants