Rollup of 6 pull requests #109791

compiler-errors · 2023-03-30T19:42:21Z

Successful merges:

Skip no_mangle if the item has no name. #109347 (Skip no_mangle if the item has no name.)
Implement current_dll_path for AIX #109522 (Implement current_dll_path for AIX)
Freshen normalizes-to hack goal RHS in the evaluate loop #109679 (Freshen normalizes-to hack goal RHS in the evaluate loop)
resolve: Minor improvements to effective visibilities #109704 (resolve: Minor improvements to effective visibilities)
Closures always implement FnOnce in new solver #109739 (Closures always implement FnOnce in new solver)
Parallel compiler cleanups #109758 (Parallel compiler cleanups)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

It helped to reuse `update_def` for the crate root, but it created confusion and caused some mistakes when I implemented rust-lang#109500

Also, `MTRef<'a, T>` is a typedef for a reference to a `T`, but in practice it's only used (and useful) in combination with `MTLock`, i.e. `MTRef<'a, MTLock<T>>`. So this commit changes it to be a typedef for a reference to an `MTLock<T>`, and renames it as `MTLockRef`. I think this clarifies things, because I found `MTRef` quite puzzling at first.

It's unused.

Skip no_mangle if the item has no name. Fixes rust-lang#109305

…rieb Implement current_dll_path for AIX AIX doesn't feature `dladdr`, use `loadquery` instead. `loadquery` is documented in https://www.ibm.com/docs/en/aix/7.2?topic=l-loadquery-subroutine.

…-2, r=lcnr,BoxyUwU Freshen normalizes-to hack goal RHS in the evaluate loop Ensure that we repeatedly equate the unconstrained RHS of the normalizes-to hack goal with the *actual* RHS of the goal, even if the normalizes-to goal loops several times and thus we replace the unconstrained RHS var repeatedly. Alternative to rust-lang#109583.

resolve: Minor improvements to effective visibilities See individual commits.

…-fnonce, r=lcnr Closures always implement `FnOnce` in new solver We should process `[closure]: FnOnce(Tys...) -> Ty` obligations *before* fallback and closure analysis. We can do this by taking advantage of the fact that `FnOnce` is always implemented by closures, even before we definitely know the closure kind. Fixes compiler-errors/next-solver-hir-issues#15 r? ``@oli-obk`` (trying to spread the reviewer load for new trait solver prs, and this one is pretty self-contained, though feel free to reassign 😸)

…jgillot Parallel compiler cleanups A few small improvements I found while looking closely at this code. r? `@cjgillot` cc `@Zoxc,` `@SparrowLii`

compiler-errors · 2023-03-30T19:42:30Z

@bors r+ rollup=never p=6

bors · 2023-03-30T19:42:32Z

📌 Commit 249198c has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2023-03-30T22:02:13Z

⌛ Testing commit 249198c with merge c1d3610...

bors · 2023-03-31T00:42:58Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing c1d3610 to master...

rust-timer · 2023-03-31T00:44:42Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#109758	4521c973bea5a2b2a923744979de8737101dd166
#109739	3eb360a582a1bc15cc9659afb8ef864097410b29
#109704	37d8233009ebcaa2398750b2f4fc8a8a2d7ce2b6
#109679	d4a1e6af162659f95f3f7713f46116d95f5e3cf8
#109522	a00d4d4bb1de2bbbf4b75d5cc113b6497c5b8084
#109347	30bab8b74c5618886e25437084c9fe1da38750a0

previous master: ec2f40c6b0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-03-31T06:06:37Z

Finished benchmarking commit (c1d3610): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.6%, 0.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.4%	[-2.4%, -2.4%]	1

Kai Luo and others added 21 commits March 23, 2023 16:50

Implement current_dll_path for AIX

6e8a828

Avoid misalign

5aad510

Address comment

82bfdc8

Check data segment range

49f63eb

Reformat codegen_fn_attrs.

84487b2

Skip no_mangle if the item has no name.

3102722

privacy: Support #![rustc_effective_visibility] on the crate root

4695ddf

effvis: Merge two similar code paths

ede21e8

effvis: Stop considering crate root its own parent

b3bfeaf

It helped to reuse `update_def` for the crate root, but it created confusion and caused some mistakes when I implemented rust-lang#109500

Freshen normalizes-to hack goal RHS in the evaluate loop

0542b0d

Remove RwLock::clone_guard.

0ccb600

It's unused.

CacheAligned and Sharded don't need to derive Clone.

44bfb65

Remove an out-of-date comment on QueryCache::lookup.

08dec89

Closures always implement FnOnce in new solver

177997e

Rollup merge of rust-lang#109347 - cjgillot:issue-109305, r=WaffleLapkin

987628e

Skip no_mangle if the item has no name. Fixes rust-lang#109305

Rollup merge of rust-lang#109522 - bzEq:aix-current-dll-path, r=Nilst…

bc7976e

…rieb Implement current_dll_path for AIX AIX doesn't feature `dladdr`, use `loadquery` instead. `loadquery` is documented in https://www.ibm.com/docs/en/aix/7.2?topic=l-loadquery-subroutine.

Rollup merge of rust-lang#109704 - petrochenkov:effvisclean, r=jackh726

fbe7383

resolve: Minor improvements to effective visibilities See individual commits.

Rollup merge of rust-lang#109758 - nnethercote:parallel-cleanups, r=c…

249198c

…jgillot Parallel compiler cleanups A few small improvements I found while looking closely at this code. r? `@cjgillot` cc `@Zoxc,` `@SparrowLii`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 31, 2023

bors merged commit c1d3610 into rust-lang:master Mar 31, 2023

rustbot added this to the 1.70.0 milestone Mar 31, 2023

This was referenced Mar 31, 2023

resolve: Restore some effective visibility optimizations #109437

Merged

Move the WorkerLocal type from the rustc-rayon fork into rustc_data_structures #107782

Merged

prioritize param env candidates if they don't guide type inference #109724

Merged

compiler-errors deleted the rollup-c3o710k branch August 11, 2023 20:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #109791

Rollup of 6 pull requests #109791

compiler-errors commented Mar 30, 2023

compiler-errors commented Mar 30, 2023

bors commented Mar 30, 2023

bors commented Mar 30, 2023

bors commented Mar 31, 2023

rust-timer commented Mar 31, 2023

rust-timer commented Mar 31, 2023

Rollup of 6 pull requests #109791

Rollup of 6 pull requests #109791

Conversation

compiler-errors commented Mar 30, 2023

compiler-errors commented Mar 30, 2023

bors commented Mar 30, 2023

bors commented Mar 30, 2023

bors commented Mar 31, 2023

rust-timer commented Mar 31, 2023

rust-timer commented Mar 31, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles