-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to collections
docs to extend
trait
#110047
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
This comment has been minimized.
This comment has been minimized.
While you're there, do you think linking |
Sure! Frankly, I would also link
|
That definitely makes sense to me. Feel free to try it and I'll see how it looks. |
Ok, this is looking great. The only thing is there are now quite a few commits. Would you be able to squish them into one? |
Sure. Just let me clone it again locally a bit later. |
and couple of its methods
Thank you for bearing with me on this one! Can I ask a side question while CI checks squashing... Why do I get the following output when command `cargo metadata` exited with an error: error: failed to load manifest for workspace member `/home/serge/Desktop/rust/src/tools/cargo`
Caused by:
failed to read `/home/serge/Desktop/rust/src/tools/cargo/Cargo.toml`
Caused by:
No such file or directory (os error 2)
cargo-fmt
... |
Ah, Rust's build system is fairly complex and complicated further by the fact it's building the compiler and tools that are used to build itself. If that makes sense. So you have to use the |
If you're interested in some of the details of the compiler's build system then Joshua Nelson's conference talk may be of interest: https://www.youtube.com/watch?v=oUIjG-y4zaA |
Ok, let's try to get this merged! @bors r+ rollup |
Totally! I was suspecting something like this.
I was cautiously looking at this
Thanks a lot: ton of new stuff and information! |
Rollup of 7 pull requests Successful merges: - rust-lang#103682 (Stabilize rustdoc `--test-run-directory`) - rust-lang#106249 (Create "suggested tests" tool in `rustbuild`) - rust-lang#110047 (Add link to `collections` docs to `extend` trait) - rust-lang#110269 (Add `tidy-alphabetical` to features in `core`) - rust-lang#110292 (Add `tidy-alphabetical` to features in `alloc` & `std`) - rust-lang#110305 (rustdoc-search: use ES6 `Map` and `Set` where they make sense) - rust-lang#110315 (Add a stable MIR way to get the main function) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
I believe it would be useful here.