-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword the docstring in todo! macro definition, fixing a typo #110104
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
library/core/src/macros/mod.rs
Outdated
/// This can be useful if you are prototyping and are just looking to have your | ||
/// code typecheck. | ||
/// code typechecked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should avoid that jargon altogether? Something like:
This can be useful if you are prototyping and just want a placeholder to let your code pass type analysis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reason for me not to use your words verbatim. Updating the PR.
@bors r+ rollup |
…mpiler-errors Rollup of 10 pull requests Successful merges: - rust-lang#96971 (Initial support for loongarch64-unknown-linux-gnu) - rust-lang#109894 (Remove Errors section from var_os docs) - rust-lang#110000 (Rename tests/ui/unique to tests/ui/box/unit) - rust-lang#110018 (Pass host linker to compiletest.) - rust-lang#110104 ( Reword the docstring in todo! macro definition, fixing a typo) - rust-lang#110113 (Fix `x test ui --target foo` when download-rustc is enabled) - rust-lang#110126 (Support safe transmute in new solver) - rust-lang#110155 (Fix typos in librustdoc, tools and config files) - rust-lang#110162 (rustdoc: remove redundant expandSection code from main.js) - rust-lang#110173 (kmc-solid: Implement `Socket::read_buf`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
No description provided.