Fix typos in compiler

[DaniPopes]

I ran typos -w compiler to fix typos in the compiler directory.

Refs #110150

[rustbot]

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in need_type_info.rs

cc @lcnr

[Noratrieb]

r? Nilstrieb

[Noratrieb]

Thanks, this is good except for one small change.

Out of curiousity: How much manual work did you have to do here? We've received typo fixing PRs of much lower quality (the quality here was great), so I'm curious to see what you've done differently. I told you to remove some bad cases on the first PR, how many did you have to remove roughly?

[Noratrieb]

And you have to run ./x.py test tests/ui --bless to bless the tests whose error message you changed.

[DaniPopes]

How much manual work did you have to do here

Just a matter of excluding false positives; the config ended up like this:

typos.toml

[files]
extend-exclude = [
    "*.json",
    "*.sh",
    "**/benches/**",
    "**/*test*/**",
    "**/*test*.rs",
    "RELEASES.md",
    "**/patches/**",
    "**/archs.rs",
    "compiler/rustc_codegen_cranelift/example/**",
    "library/core/src/unicode/unicode_data.rs",
    "src/ci/docker/**",

    ### manually vetted files
    "src/doc/unstable-book/src/compiler-flags/sanitizer.md",
    "src/doc/rustdoc/src/what-is-rustdoc.md",
    "src/tools/lint-docs/src/lib.rs",
    "library/test/src/term/terminfo/parser/compiled.rs",
    # typos already present in the `winerror.h` header file
    "library/std/src/sys/windows/c/errors.rs",
    # intentional `widnows` typo
    "compiler/rustc_lint_defs/src/builtin.rs",
    # git commit sha
    "compiler/rustc_interface/src/util.rs",

    ### [rustfmt.toml].exclude
    "/build/",
    "/*-build/",
    "/build-*/",
    "/vendor/",

    # tests for now are not formatted, as they are sometimes pretty-printing constrained
    # (and generally rustfmt can move around comments in UI-testing incompatible ways)
    "tests",

    # do not format submodules
    "library/backtrace",
    "library/portable-simd",
    "library/stdarch",
    "compiler/rustc_codegen_gcc",
    "src/doc/book",
    "src/doc/edition-guide",
    "src/doc/embedded-book",
    "src/doc/nomicon",
    "src/doc/reference",
    "src/doc/rust-by-example",
    "src/doc/rustc-dev-guide",
    "src/llvm-project",
    "src/tools/cargo",
    "src/tools/clippy",
    "src/tools/miri",
    "src/tools/rls",
    "src/tools/rust-analyzer",
    "src/tools/rustfmt",
    "src/tools/rust-installer",

    # these are ignored by a standard cargo fmt run
    "compiler/rustc_codegen_cranelift/y.rs", # running rustfmt breaks this file
    "compiler/rustc_codegen_cranelift/example",
    "compiler/rustc_codegen_cranelift/scripts",
]
ignore-parent = true

[default]
binary = false
locale = "en"
extend-ignore-identifiers-re = [
    # workaround for no way to specify regex flags
    "[nN][tT][oO]",
    "[nN][uU][mM][eE][rR]",
    "[bB][aA][rR][eE]",
    "[pP][rR][eE][vV]",
    "[rR][eE][tT]",
    "[gG][oO][eE][sS]",
    "[oO][tT]",
    "[iI][nN][oO][uU][tT]",
    "[nN][dD]",
    "[tT][hH][nN]",
    "[kK][eE][tT]",
    "[mM][iI][sS]",
    "[oO][pP][tT][iI][nN]",
    "[rR][eE][lL][aA]",
    "[sS][eE][hH]",
    "[wW][tT][hH]",
    "[tT][pP][yY][oO]",
    "[lL][iI][tT][sS]?",
    "RealOLT",
    "OLT",
    "LT",
    "VALUEs",
    "tolen",
    "makro",
    # library/alloc/src/collections/vec_deque/**
    "deques",
    # library/core/src/str/mod.rs
    "pard",
    # https://docs.rs/wasi/latest/wasi/constant.ERRNO_ACCES.html
    "ERRNO_ACCES",
    # /usr/x86_64-w64-mingw32/include/winerror.h
    "ERROR_FILENAME_EXCED_RANGE",
    # drain_unstalled_obligations
    "unstalled",
    "ba",
    "fpr",
    "[fF][oO]",
]

[default.extend-identifiers]
MisMatch = "Mismatch"
FieldMisMatch = "FieldMismatch"

This takes care of most of the simple fixes, while the remaining have to be disambiguated manually which is not that bad since the error messages are pretty detailed with location and possible fixes.

I told you to remove some bad cases on the first PR, how many did you have to remove roughly?

Nothing except the ones you asked me to remove in the initial remove, didn't find anything after double checking.

[Noratrieb]

@bors r+

We generally have a policy against automated typo fixing PRs because of some bad experiences, which I didn't apply here because the PR was good :).

But we are interested in looking into ways to catch such typos more automatically in CI (and if it's good enough, may want to adopt that), so it you have any ideas on how it could be done with a low enough false positive rate feel free to share that on zulip.

[bors]

📌 Commit 40f12c6 has been approved by Nilstrieb

It is now in the queue for this repository.