update Miri #110168
Merged
update Miri #110168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit a warning when Miri is used with optimizations This may address rust-lang/miri#2797, by clarifying to the user what is going on and what the consequences of their choices are. Fixes rust-lang/miri#2797
…d the same speed as the host system.
Update the virtual clock in isolation mode to step forward with around the same speed as the host system. Before this, the 1s sleep test took around 4 minutes on my machine.
move reject with isolation logic in fcntl This PR moves the block of logic inside `fcntl` to reject if isolation is enabled into the branch checking if the command is `F_FULLFSYNC` on apple. This allows `fcntl` to duplicate file descriptors while using isolation. This means we can now run the tokio tests with isolation. This PR allows moves the now passing `fcntl` logic from `libc-fs-with-isolation.rs` into two different tests: - `fcntl(1, libc::F_DUPFD, 0)` succeeds with isolation - `fcntl(1, libc::F_FULLFSYNC, 0)` fails with isolation on MacOS
Also explain what needs to be done.
Have the miri cronjob link to the failed run. Also explain what needs to be done to resolve the failing CI.
Correctly quote env vars in single quoted string in bash single quotes don't allow env vars. So we unquote the single quote, start a double quote for where we use env vars and then unquote the double quote and continue with the single quote.
…li-obk Add link for tree borrows similar to stacked borrows `@Vanille-N` does it look ok to you?
The panic test is now counted as an error test; we encounter a Terminate terminator, and emit an interpreter error, as opposed to just terminating due to a panic. So this test should have broken with rust-lang#102906 but wasn't because the Miri test suite is currently broken in rust-lang/rust: rust-lang#110102
rustbot
added
the
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri |
|
Does this also fix the miri-test-libstd failures? |
|
Ah looks like that still needs investigation. Anyway let's sync first. @bors r+ p=1 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (8e1162f): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly, this should ensure that the Miri test suite passes in this repo, when the issue is fixed.
r? @oli-obk