unused_parens now fires on cast expression #110189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
|
rustbot
added
S-waiting-on-review
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
6 tasks
b-naber
reviewed
Apr 11, 2023
b-naber
reviewed
Apr 11, 2023
b-naber
reviewed
Apr 11, 2023
This comment has been minimized.
This comment has been minimized.
KisaragiEffective
force-pushed
the
unused-paren-followed-by-cast
branch
from
920f651 to
8488fd0
Compare
|
(force-pushed to drop accidental changes in stdarch submodule) should it be fixed in this PR as well as other occurrences? |
@KisaragiEffective I'd suggest doing so if it isn't against the reviewer's descretion since that'll be the only way the CI passes and the compiler builds fully :) |
|
submitted rust-lang/stdarch#1411, marking this as a draft until it is synced. |
This comment has been minimized.
This comment has been minimized.
|
It's merged 🚀 |
|
Can you please squash your commits? |
Sure! However, I'd like to rebase (and squash) after stdarch update is landed in order to reduce force-push, so I'll submit another PR first. |
|
submitted #110285, this PR remains to be a draft. Once it has approved and merged, I will rebase and squash commit. |
|
☔ The latest upstream changes (presumably #110458) made this pull request unmergeable. Please resolve the merge conflicts. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 24, 2023
…Amanieu stdarch: update submodule We need [this commit](rust-lang/stdarch@cf3deea) introduced by [stdarch#1411](rust-lang/stdarch#1411) in order to merge rust-lang#110189.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 9, 2023
…anieu stdarch: update submodule We need [this commit](rust-lang/stdarch@cf3deea) introduced by [stdarch#1411](rust-lang/stdarch#1411) in order to merge rust-lang#110189. Note to myself: `git pull && git submodule update --remote library/stdarch`
KisaragiEffective
force-pushed
the
unused-paren-followed-by-cast
branch
from
8488fd0 to
1810b24
Compare
KisaragiEffective
force-pushed
the
unused-paren-followed-by-cast
branch
from
56f75aa to
04f6320
Compare
This comment has been minimized.
This comment has been minimized.
|
It looks like another PR to stdarch is needed. |
RalfJung
reviewed
Jun 19, 2023
| @@ -198,7 +198,7 @@ fn casts() { | |||
| assert_eq::<i32>(f32::INFINITY as i32, i32::MAX); | |||
| assert_eq::<i32>(f32::NEG_INFINITY as i32, i32::MIN); | |||
| assert_eq::<i32>(f32::NAN as i32, 0); | |||
| assert_eq::<i32>((-f32::NAN) as i32, 0); | |||
There was a problem hiding this comment.
I don't think we should lint against (-expr) as i32. Looking at -expr as i32 I have no idea whether the as or the - are executed first, and I might care about that (in particular when casting to an unsigned type). (The formatting indicates that - goes first but I don't know if that actually matches how this is parsed.)
Parentheses to disambiguate parsing precedence are a good thing, we should not steer people away from them.
There was a problem hiding this comment.
I agreed :)
There was a problem hiding this comment.
Thanks! The diff in the Miri test can hopefully be removed then. :)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
RalfJung
reviewed
Jun 20, 2023
| // cast is left-assoc | ||
| let _ = (true as u8) as u16; | ||
| //~^ WARN unnecessary parentheses around cast expression | ||
| // should not fire |
There was a problem hiding this comment.
Please add unary - to this block (and other unary operator as well?)
There was a problem hiding this comment.
Does your intention include *expr as Ty and &expr as Ty?
|
☔ The latest upstream changes (presumably #113151) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@KisaragiEffective any updates on it? |
|
Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks |
Dylan-DPC
added
S-inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close rust-lang/rust-clippy#10557.
close rust-lang/rust-clippy#10625.
@llogiq suggested submit PR to solve the issue.