Use the LLVM option NoTrapAfterNoreturn #110494
Conversation
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
r? @nikic |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 6fa99de with merge dfdcb90ce055efdcb7fbbc19971eed7bb3ba284c... |
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (dfdcb90ce055efdcb7fbbc19971eed7bb3ba284c): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
rustbot
removed
the
S-waiting-on-perf
|
Shaved off 4 KiB from the "minimal size" Rust hello world binary (https://perf.rust-lang.org/compare.html?start=de96f3d8735b70d5dc1ca178aaee198b329b8f3d&end=dfdcb90ce055efdcb7fbbc19971eed7bb3ba284c&stat=size%3Alinked_artifact&showRawData=true). Not bad :) |
|
That's actually more than I expected. I wonder where it's all going? I suppose it must be unblocking some other optimisation pass. |
|
The MCP for this Pull request has been accepted, so it should be okay to merge now. |
|
@bors r+ rollup=never |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 6fa99de with merge 524076fadf02b06596a6e1ddd0deea5a679f2e58... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Use the LLVM option NoTrapAfterNoreturn Use this LLVM option: https://llvm.org/doxygen/classllvm_1_1TargetOptions.html#acd83fce25de1ac9f6c975135a8235c22 when TrapUnreachable is enabled. This prevents codegenning unnecessary double-traps in some situations. See further discussion here: rust-lang/compiler-team#618
|
Is bors okay? This PR seems to be the only one marked
S-waiting-on-bors
|
|
@bors retry |
|
I guess it glitched, but it's back in the approved queue at the top now. |
Use the LLVM option NoTrapAfterNoreturn Use this LLVM option: https://llvm.org/doxygen/classllvm_1_1TargetOptions.html#acd83fce25de1ac9f6c975135a8235c22 when TrapUnreachable is enabled. This prevents codegenning unnecessary double-traps in some situations. See further discussion here: rust-lang/compiler-team#618
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Use the LLVM option NoTrapAfterNoreturn Use this LLVM option: https://llvm.org/doxygen/classllvm_1_1TargetOptions.html#acd83fce25de1ac9f6c975135a8235c22 when TrapUnreachable is enabled. This prevents codegenning unnecessary double-traps in some situations. See further discussion here: rust-lang/compiler-team#618
|
Hmm, a stack overflow in rustdoc on mingw. That's unfortunate. I'm downloading mingw now, does anyone have any insight into why that might have happened? |
Use the LLVM option NoTrapAfterNoreturn Use this LLVM option: https://llvm.org/doxygen/classllvm_1_1TargetOptions.html#acd83fce25de1ac9f6c975135a8235c22 when TrapUnreachable is enabled. This prevents codegenning unnecessary double-traps in some situations. See further discussion here: rust-lang/compiler-team#618
|
💔 Test failed - checks-actions |
|
maybe the stackoverflow was spurious.. let's just try this again and see what happens |
bors
added
S-waiting-on-bors
|
by the way, for debugging local failures, you don't have to install anything except docker, you can use |
|
☀️ Test successful - checks-actions |
|
ha, fun. I found this PR while scrolling through old PRs. Next time, feel free to ask on https://rust-lang.zulipchat.com/ if you're facing issues and don't get a response on the PR. |
|
Well that saves me some time! I was still planning to come back to this eventually. Thanks! |
|
Finished benchmarking commit (02ad667): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 672.461s -> 672.679s (0.03%) |
Use this LLVM option: https://llvm.org/doxygen/classllvm_1_1TargetOptions.html#acd83fce25de1ac9f6c975135a8235c22 when TrapUnreachable is enabled. This prevents codegenning unnecessary double-traps in some situations.
See further discussion here: rust-lang/compiler-team#618