Rollup of 10 pull requests #110546
Merged
Rollup of 10 pull requests #110546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* although * correct * granular * libunwind * repository * section Signed-off-by: Josh Soref <[email protected]>
* architecture * configures * preparation * toolstate * unknown Signed-off-by: Josh Soref <[email protected]>
This is no longer necessary now that the llvm in `rust-dev` matches the one in `rustc`.
Bootstrap was setting LD_LIBRARY_PATH for bootstrap tools in `tool_cmd`, and rustc inherited that environment. That broke when download-rustc was enabled; see the new comment for details.
When building locally, we never generate a `share` directory in the local sysroot. However, when we download the `rustc` component from ci, it includes a `share/man` directory in the sysroot. The `run-make/translation` test assumed that it didn't exist, and would create a link from `fakeroot` to the real share directory, and write symbolic links into it. Change it not to create the link, so that rustc doesn't try to load multiple copies of the same `.ftl` file.
…correct exit code
Before, it only worked for numbers, not strings.
This also makes some other minor cleanups: - Suggest `python x.py` on windows instead of `./x.py`, which usually doesn't work - Move the "Configure and Make" section to a subsection of "Building on Unix" - Mention `config.toml` earlier - Suggest `x.py setup user` on Windows, since `configure` won't work
'./configure' now checks if 'config.toml' exists before writing to that destination Fixes rust-lang#110109 Instead of overwriting the current `config.toml` file, exit the `./configure` script with a message stating why.
…lbertlarsan68 Spelling src bootstrap The various src/* items seem slightly disparate, so I'm doing src/* individually. split from rust-lang#110392
…rsan68 Spelling src ci The various src/* items seem slightly disparate, so I'm doing src/* individually. split from rust-lang#110392
…rtlarsan68 Don't special-case download-rustc in `maybe_install_llvm` This is no longer necessary now that the llvm in `rust-dev` matches the one in `rustc`. cc rust-lang#110490 (comment), rust-lang#110263
…san68 Fix `x test lint-docs linkchecker` when download-rustc is enabled Bootstrap was setting LD_LIBRARY_PATH for bootstrap tools in `tool_cmd`, and rustc inherited that environment. That broke when download-rustc was enabled; see the new comment for details. Fixes rust-lang#110354
… r=albertlarsan68 Fix `tests/run-make-translation` when download-rustc is enabled When building locally, we never generate a `share` directory in the local sysroot. However, when we download the `rustc` component from ci, it includes a `share/man` directory in the sysroot. The `run-make/translation` test assumed that it didn't exist, and would create a link from `fakeroot` to the real share directory, and write symbolic links into it. Change it not to create the link, so that rustc doesn't try to load multiple copies of the same `.ftl` file. Fixes rust-lang#110357.
small type system cleanup
…l-trait-not-public, r=notriddle Missing blanket impl trait not public Fixes rust-lang#94183. The problem was that we should have checked if the trait was reachable instead of only "directly public". r? `@notriddle`
Fix wrong comment in rustc_hir/src/hir.rs
Fix various configure bugs Fixes rust-lang#107050. Fixes rust-lang#108928. Closes rust-lang#108641. I recommend reading this commit-by-commit to see the commit descriptions, but the code changes are small. This also changes the README to suggest `configure` instead of `printf`, as well as a few other cleanups described in the commit message.
rustbot
added
A-meta
rustbot
added
T-infra
|
@bors r+ rollup=never p=10 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 0820e31 with merge d7c55ca384776ab81435ed4b929c47e2b0238da6... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry no longs |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: df0d9b492d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 19, 2023
|
Finished benchmarking commit (9c51cf7): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
maybe_install_llvm#110515 (Don't special-case download-rustc inmaybe_install_llvm)x test lint-docs linkcheckerwhen download-rustc is enabled #110521 (Fixx test lint-docs linkcheckerwhen download-rustc is enabled)tests/run-make-translationwhen download-rustc is enabled #110525 (Fixtests/run-make-translationwhen download-rustc is enabled)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup