Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused std::sys_common::thread_local_key::Key #110898

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Remove unused std::sys_common::thread_local_key::Key #110898

merged 2 commits into from
Apr 28, 2023

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Apr 27, 2023

Part of #110897

This Key type seems unused. Let's remove it and see if anything explodes. :)

@m-ou-se m-ou-se added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-thread-locals Area: Thread local storage (TLS) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 27, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2023
@rustbot

This comment was marked as off-topic.

Sign in to view
@m-ou-se m-ou-se mentioned this pull request Apr 27, 2023
Open
24 tasks
@cuviper
Copy link
Member

cuviper commented Apr 27, 2023

Let's remove it and see if anything explodes. :)

🙈

@bors r+

@bors
Copy link
Contributor

bors commented Apr 27, 2023

📌 Commit 0b3073a has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2023
@JohnTitor JohnTitor mentioned this pull request Apr 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2023
@bors
Auto merge of rust-lang#110919 - JohnTitor:rollup-9phs2vx, r=JohnTitor
033aa09 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#109702 (configure --set support list as arguments)
 - rust-lang#110620 (Document `const {}` syntax for `std::thread_local`.)
 - rust-lang#110721 (format panic message only once)
 - rust-lang#110881 (refactor(docs): remove macro resolution fallback)
 - rust-lang#110893 (remove inline const deadcode in typeck)
 - rust-lang#110898 (Remove unused std::sys_common::thread_local_key::Key)
 - rust-lang#110909 (Skip `rustc` version detection on macOS)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 75be558 into rust-lang:master Apr 28, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 28, 2023
@m-ou-se m-ou-se deleted the remove-unused-thread-local-key branch April 28, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
A-thread-locals Area: Thread local storage (TLS) C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@m-ou-se @rustbot @cuviper @bors