fix: 🐛 etc/bash_complettion -> src/etc/... to avoid copy error #110906
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @albertlarsan68 (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-author
chore: 🎨 format dist.rs
ekusiadadus
force-pushed
the
ekusiadadus/fix-bash-complete-etc
branch
from
3106ea3 to
08ce68b
Compare
|
@bors r=albertlarsan68 oh...sorry:( |
|
@ekusiadadus: 🔑 Insufficient privileges: Not in reviewers |
|
@rustbot review @albertlarsan68 Thanks for your review. I've squashed commits 🙇 |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (d300bff): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 646.591s -> 646.557s (-0.01%) |
|
Why is this installing under |
|
I've been studying the Rust compiler through this guide. Upon running x.py, it required sudo permissions. I'm wondering if this is something that needs to be fixed. |
|
Which command needed root/sudo permissions? I've never seen that problem myself. I suppose |
|
The As I'm a novice in terms of compiler and Linux, there may be errors in this pull request. I would appreciate your feedback or advice on this matter. |
|
That's really weird -- |
|
I'm out and about right now, so I can't share my cargo.toml. I'll share it later. |
|
It could be Here's how Lines 374 to 381 in 05b82e5 |
|
This was my config.toml # Use different pre-set defaults than the global defaults.
#
# See `src/bootstrap/defaults` for more information.
# Note that this has no default value (x.py uses the defaults in `config.example.toml`).
profile = 'user'
# Keeps track of the last version of `x.py` used.
# If `changelog-seen` does not match the version that is currently running,
# `x.py` will prompt you to update it and to read the changelog.
# See `src/bootstrap/CHANGELOG.md` for more information.
changelog-seen = 2
[llvm]
[build]
# Arguments passed to the `./configure` script, used during distcheck. You
# probably won't fill this in but rather it's filled in by the `./configure`
# script. Useful for debugging.
configure-args = ['--set', 'install.prefix=~/.rustup/toolchains/dev']
[install]
# Where to install the generated toolchain. Must be an absolute path.
prefix = '/home/ekusiadadus/.rustup/toolchains/dev'
[rust]
[target.x86_64-unknown-linux-gnu]
[dist] |
|
OK, so yes, the problem was that you tried to install while the So I propose to (1) revert this PR and (2) file an issue to sanity-check these paths. |
|
I completely agree with your proposal. However, when reverting the PR, I'd like you to check whether it actually works. As there are other issues raised, it seems to me that this problem might not be resolved by just reverting. Could you please check if it's possible to revert this PR? |
|
It is possible, just run |
Well, I feel confident that it was working before, at least in the ways that I use it, and I only noticed this PR because it stopped working for me. But that's the challenge, of course, that people may try many different configurations with varying success... |
|
Please check this PR. |
|
Thanks for your help 🙇 |
See #113580, and feel free to discuss that further, of course. |
Revert "fix: 🐛 etc/bash_complettion -> src/etc/... to avoid copy … ## why - [x] revert my broken PR rust-lang#110906 This reverts commit 08ce68b.
Revert "fix: 🐛 etc/bash_complettion -> src/etc/... to avoid copy … ## why - [x] revert my broken PR rust-lang#110906 This reverts commit 08ce68b.
why
I got an error on executing
./x.py build && ./x.py install.Found creating some folder in
/etc/bash_completion.d/, It appears to be incorrect to attempt to create a folder in/etc/bash_completion.d/, as this proccess requiressudo.Fixes #111653
Error Log