Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pulldown-cmark to 0.9.3 #111152

Merged
merged 4 commits into from
May 26, 2023
Merged

update pulldown-cmark to 0.9.3 #111152

merged 4 commits into from
May 26, 2023

Conversation

lukas-code
Copy link
Member

@lukas-code lukas-code commented May 3, 2023 •
edited
Loading

This PR updates pulldown-cmark to version 0.9.3, which does two main things:

Full changelog: pulldown-cmark/pulldown-cmark#646

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 3, 2023
@lukas-code

This comment was marked as resolved.

Sign in to view
@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2023
@lukas-code lukas-code force-pushed the markdown-parsers-are-hard branch from 9740c4c to b451c0c Compare May 18, 2023 16:41
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-testsuite Area: The testsuite used to check the correctness of rustc labels May 18, 2023
@lukas-code lukas-code changed the title update pulldown-cmark + add regression test for double backtick broken link rustdoc ICE update pulldown-cmark to 0.9.3 May 21, 2023
@lukas-code lukas-code force-pushed the markdown-parsers-are-hard branch from b451c0c to 8a5eb55 Compare May 21, 2023 15:32
@lukas-code lukas-code marked this pull request as ready for review May 21, 2023 15:32
@rustbot
Copy link
Collaborator

rustbot commented May 21, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@lukas-code
Copy link
Member Author

r? rustdoc @rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels May 21, 2023
@lukas-code
Copy link
Member Author

lukas-code commented May 21, 2023 •
edited
Loading

The strikethrough change might be worth documenting in @rustbot label relnotes

I'm not sure if this counts as a new feature or is just a bug fix, since we already document that rustdoc supports GFM strikethrough.

/// ~~old~~ ~new~
pub fn strike() {}

before:
single strike + tildes

after:
double strike

@rustbot rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label May 21, 2023
@lukas-code lukas-code force-pushed the markdown-parsers-are-hard branch from 8a5eb55 to 073e19f Compare May 22, 2023 09:53
@lukas-code
Copy link
Member Author

r? @GuillaumeGomez maybe?

@rustbot rustbot assigned GuillaumeGomez and unassigned jsha May 25, 2023
@GuillaumeGomez
Copy link
Member

Thanks for the update and the new test! Can you also update this section of the rustdoc book please? You can edit it in src/doc/rustdoc/.

Lukas Markeffsky added 2 commits May 25, 2023 13:27
rustdoc: add test for strikethrough with single tildes
28ce0b9 
Also merge the two almost identical strikethrough tests together and document what the test tests.
rustdoc book: document single tilde strikethrough
c2a446a
@lukas-code lukas-code force-pushed the markdown-parsers-are-hard branch from 073e19f to c2a446a Compare May 25, 2023 13:31
@lukas-code
Copy link
Member Author

I've added a comment to the test and updated the rustdoc book.

I also verified that the single tilde striketrough actually renders correctly in the book.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 25, 2023

📌 Commit c2a446a has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 25, 2023
@matthiaskrgr
Rollup merge of rust-lang#111152 - lukas-code:markdown-parsers-are-ha…
b35b134 
…rd, r=GuillaumeGomez

update `pulldown-cmark` to `0.9.3`

This PR updates `pulldown-cmark` to version `0.9.3`, which does two main things:
* Pulls in pulldown-cmark/pulldown-cmark#643 to fix rust-lang#111117
* Allows parsing strikethrough with single tildes, e.g. `~foo~` -> ~foo~. This matches the [GFM spec](https://github.github.com/gfm/#strikethrough-extension-).

Full changelog: pulldown-cmark/pulldown-cmark#646
@matthiaskrgr matthiaskrgr mentioned this pull request May 25, 2023
Closed
@compiler-errors compiler-errors mentioned this pull request May 25, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2023
@bors
Auto merge of rust-lang#111960 - compiler-errors:rollup-onka2dl, r=co…
0004b3b 
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#107522 (Add Median of Medians fallback to introselect)
 - rust-lang#111152 (update `pulldown-cmark` to `0.9.3`)
 - rust-lang#111757 (Consider lint check attributes on match arms)
 - rust-lang#111831 (Always capture slice when pattern requires checking the length)
 - rust-lang#111929 (Don't print newlines in APITs)
 - rust-lang#111945 (Migrate GUI colors test to original CSS color format)
 - rust-lang#111950 (Remove ExpnKind::Inlined.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bd7e8b5 into rust-lang:master May 26, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 26, 2023
@lukas-code lukas-code deleted the markdown-parsers-are-hard branch May 26, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

ICE in nightly rustdocs
5 participants
@lukas-code @rustbot @GuillaumeGomez @bors @jsha