new tool `rustdoc-gui-test` #111348

onur-ozkan · 2023-05-08T11:28:39Z

Implements new tool rustdoc-gui-test that allows using compiletest headers for rustdoc-gui tests.

rustbot · 2023-05-08T11:28:57Z

Failed to set assignee to albertlarsan68: cannot assign: HTTP status server error (502 Bad Gateway) for url (https://api.github.com/repos/rust-lang/rust/issues/111348/assignees)

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

rustbot · 2023-05-08T11:29:00Z

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

onur-ozkan · 2023-05-08T14:55:09Z

How does this change looks like ? Is it overkill to use compiletest_rs for parsing the headers? I didn't want to implement it again to avoid code duplication in the repository.

cc @jyn514

jyn514 · 2023-05-08T15:26:19Z

How big is the function you're using? If it's not giant, I'd rather move just that function to build_helper so we don't have to pull in all of compiletest.

onur-ozkan · 2023-05-08T15:51:05Z

How big is the function you're using? If it's not giant, I'd rather move just that function to build_helper so we don't have to pull in all of compiletest.

Moving is even more complex because it requires a lot of functions and types to move. Alternative way to adding compiletest_rs dependency is writing straight forward parsing function with simple config type for compile-args and run-flags. But that makes me feel uncomfortable since it requires maintaining multiple parsing implementations(with different algorithms) that does the same thing.

Mark-Simulacrum · 2023-05-08T16:00:13Z

I think the right solution is to move rustdoc-gui to src/tools/compiletest so that all flags can be supported.

onur-ozkan · 2023-05-08T16:08:50Z

I think the right solution is to move rustdoc-gui to src/tools/compiletest so that all flags can be supported.

They are quite different things IMO. rustdoc-gui has tests that are defined as crates, and the way it performs tests is completely different(uses goml files with browser-ui-test npm package) than the rest. We can still support all the flags from compiletest_rs

--

If pulling compiletest from https://github.com/Manishearth/compiletest-rs is the problem, maybe we can use compiletest locally from src/tools/compiletest?

Mark-Simulacrum · 2023-05-08T16:12:15Z

A separate crate like compiletest (e.g., src/tools/rustdoc-gui) would avoid everyone building Rust needing to compile the extra dependencies, if you don't want to build it into compiletest proper.

onur-ozkan · 2023-05-09T18:06:45Z

@rustbot blocked

Signed-off-by: ozkanonur <[email protected]>

oli-obk · 2023-05-26T13:49:20Z

@bors r=albertlarsan68,oli-obk

bors · 2023-05-26T13:49:23Z

📌 Commit 0fb171795ce80fae65d381521d5bafcc0937affa has been approved by albertlarsan68,oli-obk

It is now in the queue for this repository.

onur-ozkan · 2023-05-26T14:00:04Z

@bors r-

forgot to realign this
https://github.com/rust-lang/rust/blob/0fb171795ce80fae65d381521d5bafcc0937affa/triagebot.toml#L664-L667

onur-ozkan · 2023-05-26T14:04:44Z

@bors r=albertlarsan68,oli-obk

bors · 2023-05-26T14:04:46Z

📌 Commit c7cec29 has been approved by albertlarsan68,oli-obk

It is now in the queue for this repository.

…-flags, r=albertlarsan68,oli-obk new tool `rustdoc-gui-test` Implements new tool `rustdoc-gui-test` that allows using compiletest headers for `rustdoc-gui` tests.

bors · 2023-05-27T04:20:48Z

⌛ Testing commit c7cec29 with merge dbfc95f...

bors · 2023-05-27T07:02:42Z

☀️ Test successful - checks-actions
Approved by: albertlarsan68,oli-obk
Pushing dbfc95f to master...

rust-timer · 2023-05-27T08:18:24Z

Finished benchmarking commit (dbfc95f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[1.0%, 1.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 645.695s -> 643.935s (-0.27%)

GuillaumeGomez · 2023-06-01T10:24:36Z

tests/rustdoc-gui/source-anchor-scroll.goml

@@ -8,13 +8,13 @@ set-window-size: (600, 800)
 assert-property: ("html", {"scrollTop": "0"})

 click: '//a[text() = "barbar"]'
-assert-property: ("html", {"scrollTop": "125"})
+assert-property: ("html", {"scrollTop": "149"})


Why did these values change? Unless you changed the default size of the page, they should not have been updated.

#111348 (comment)

I see, thanks! But why generating the links to def all the time then? Was there an issue to generate it only for one crate? It's a nightly-only option, so it should not be included all the time because it prevents us to test the almost 100% use-case, which is problematic imo.

GuillaumeGomez · 2023-06-01T10:25:44Z

Would have been nice if the rustdoc team was contacted for the changes in the rustdoc GUI test. I'm very nervous about this change as I don't understand why it's needed.

onur-ozkan · 2023-06-01T10:30:12Z

I don't understand why it's needed.

#111348 (comment)

onur-ozkan · 2023-06-01T10:36:31Z

Would have been nice if the rustdoc team was contacted for the changes in the rustdoc GUI test.

You are right, we forgot doing that, sorry about that.

The main reason for having this tool was to prevent the need for manually inserting test flags in bootstrap side. If we were to directly use compiletest in bootstrap, it would have made the bootstrapping process longer.

GuillaumeGomez · 2023-06-01T10:40:22Z

I'm fine with the tool (and nice job!), just would have preferred to be pinged for the GUI test change to at least be aware of it.

onur-ozkan · 2023-06-01T10:41:52Z

just would have preferred to be pinged for the GUI test change to at least be aware of it.

absoluletely true, again sorry for missing that

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 8, 2023

This comment has been minimized.

Sign in to view

onur-ozkan force-pushed the remove-hardcoded-rustdoc-flags branch 2 times, most recently from 84e2def to 380b7d7 Compare May 8, 2023 14:53

onur-ozkan changed the title ~~[wip] remove hardcoded RUSTDOCFLAGS flags in bootstrap~~ [wip] implement compiletest headers to rustdoc-gui May 8, 2023

onur-ozkan force-pushed the remove-hardcoded-rustdoc-flags branch 2 times, most recently from b8431c2 to ccfb1e8 Compare May 8, 2023 15:07

onur-ozkan marked this pull request as ready for review May 8, 2023 15:07

onur-ozkan changed the title ~~[wip] implement compiletest headers to rustdoc-gui~~ implement compiletest headers to rustdoc-gui May 8, 2023

onur-ozkan marked this pull request as draft May 8, 2023 16:32

onur-ozkan changed the title ~~implement compiletest headers to rustdoc-gui~~ create new tool rustdoc-gui-tests May 8, 2023

onur-ozkan changed the title ~~create new tool rustdoc-gui-tests~~ create new tool rustdoc-gui-test May 8, 2023

onur-ozkan added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2023

onur-ozkan mentioned this pull request May 9, 2023

add lib module to src/tool/compiletest #111398

Closed

onur-ozkan changed the title ~~create new tool rustdoc-gui-test~~ new tool rustdoc-gui-test May 9, 2023

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 9, 2023

add lib module to src/tool/compiletest

548978f

Signed-off-by: ozkanonur <[email protected]>

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2023

add rustdoc-gui-test tool in triagebot.toml

c7cec29

onur-ozkan force-pushed the remove-hardcoded-rustdoc-flags branch from 0fb1717 to c7cec29 Compare May 26, 2023 14:00

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 26, 2023

compiler-errors mentioned this pull request May 26, 2023

Rollup of 7 pull requests #112003

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label May 27, 2023

bors merged commit dbfc95f into rust-lang:master May 27, 2023

rustbot added this to the 1.71.0 milestone May 27, 2023

onur-ozkan deleted the remove-hardcoded-rustdoc-flags branch May 27, 2023 07:08

bors mentioned this pull request May 27, 2023

make noop_method_call warn by default #111916

Merged

GuillaumeGomez reviewed Jun 1, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new tool `rustdoc-gui-test` #111348

new tool `rustdoc-gui-test` #111348

onur-ozkan commented May 8, 2023 •

edited

Loading

rustbot commented May 8, 2023

rustbot commented May 8, 2023

This comment has been minimized.

onur-ozkan commented May 8, 2023

jyn514 commented May 8, 2023

onur-ozkan commented May 8, 2023

Mark-Simulacrum commented May 8, 2023

onur-ozkan commented May 8, 2023 •

edited

Loading

Mark-Simulacrum commented May 8, 2023

onur-ozkan commented May 9, 2023

oli-obk commented May 26, 2023

bors commented May 26, 2023

onur-ozkan commented May 26, 2023

onur-ozkan commented May 26, 2023

bors commented May 26, 2023

bors commented May 27, 2023

bors commented May 27, 2023

rust-timer commented May 27, 2023

GuillaumeGomez Jun 1, 2023

onur-ozkan Jun 1, 2023

GuillaumeGomez Jun 1, 2023

GuillaumeGomez commented Jun 1, 2023

onur-ozkan commented Jun 1, 2023 •

edited

Loading

onur-ozkan commented Jun 1, 2023

GuillaumeGomez commented Jun 1, 2023

onur-ozkan commented Jun 1, 2023

new tool rustdoc-gui-test #111348

new tool rustdoc-gui-test #111348

Conversation

onur-ozkan commented May 8, 2023 • edited Loading

rustbot commented May 8, 2023

rustbot commented May 8, 2023

This comment has been minimized.

onur-ozkan commented May 8, 2023

jyn514 commented May 8, 2023

onur-ozkan commented May 8, 2023

Mark-Simulacrum commented May 8, 2023

onur-ozkan commented May 8, 2023 • edited Loading

Mark-Simulacrum commented May 8, 2023

onur-ozkan commented May 9, 2023

oli-obk commented May 26, 2023

bors commented May 26, 2023

onur-ozkan commented May 26, 2023

onur-ozkan commented May 26, 2023

bors commented May 26, 2023

bors commented May 27, 2023

bors commented May 27, 2023

rust-timer commented May 27, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

GuillaumeGomez Jun 1, 2023

Choose a reason for hiding this comment

onur-ozkan Jun 1, 2023

Choose a reason for hiding this comment

GuillaumeGomez Jun 1, 2023

Choose a reason for hiding this comment

GuillaumeGomez commented Jun 1, 2023

onur-ozkan commented Jun 1, 2023 • edited Loading

onur-ozkan commented Jun 1, 2023

GuillaumeGomez commented Jun 1, 2023

onur-ozkan commented Jun 1, 2023

new tool `rustdoc-gui-test` #111348

new tool `rustdoc-gui-test` #111348

onur-ozkan commented May 8, 2023 •

edited

Loading

onur-ozkan commented May 8, 2023 •

edited

Loading

onur-ozkan commented Jun 1, 2023 •

edited

Loading