-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark internal functions and traits unsafe to reflect preconditions #111609
Conversation
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
This comment has been minimized.
This comment has been minimized.
bbcefa7
to
7748109
Compare
Yeah fair enough.
Might have been the plan at one point, but at the moment it's not. This can already be accomplished in some way with io::Write after all. @bors r+ rollup |
Rollup of 6 pull requests Successful merges: - rust-lang#111501 (MIR drive-by cleanups) - rust-lang#111609 (Mark internal functions and traits unsafe to reflect preconditions) - rust-lang#111612 (Give better error when collecting into `&[T]`) - rust-lang#111756 (Rename `{drop,forget}_{copy,ref}` lints to more consistent naming) - rust-lang#111843 (move lcnr to only review types stuff) - rust-lang#111844 (Migrate GUI colors test to original CSS color format) r? `@ghost` `@rustbot` modify labels: rollup
No semantics are changed in this PR; I only mark some functions and and a trait
unsafe
which already had implicit preconditions. Although it seems somewhat redundant fornumfmt::Part::Copy
to contain a&[u8]
instead of a&str
, given that all of its current consumers ultimately expect valid UTF-8. Is the type also intended to work for byte-slice formatting in the future?