Diagnostic namespace #111780

weiznich · 2023-05-20T09:14:47Z

This PR implements the basic infrastructure for accepting the #[diagnostic] attribute tool namespace as specified in rust-lang/rfcs#3368. Note: This RFC is not merged yet, but it seems like it will be accepted soon. I open this PR early on to get feedback on the actual implementation as soon as possible. This hopefully enables getting at least the diagnostic namespace to stable rust "soon", so that crates do not need to bump their MSRV if we stabilize actual attributes in this namespace.

This PR only adds infrastructure accept attributes from this namespace, it does not add any specific attribute. Therefore the compiler will emit a lint warning for each attribute that's actually used. This namespace is added behind a feature flag, so it will be only available on a nightly compiler for now.

cc @estebank as they've supported me in planing, specifying and implementing this feature.

rustbot · 2023-05-20T09:14:55Z

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-05-20T09:14:59Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

compiler/rustc_feature/src/active.rs

matthewjasper · 2023-05-20T23:39:09Z

cc @petrochenkov

compiler/rustc_lint_defs/src/builtin.rs

compiler/rustc_hir/src/def.rs

weiznich · 2023-06-02T06:53:44Z

I've rebased this on top of #112086 to resolve @petrochenkov concerns. Merging this PR needs to wait till #112086 has landed.

compiler/rustc_hir/src/def.rs

weiznich · 2023-06-08T08:35:36Z

To just leave that as comment here: I'm on vacation for the next weeks, so I likely won't be able to update the PR for potential conflicts in that time. Hopefully the name resolution fix is merged when I'm back. If necessary I will fix conflicts after I'm back

weiznich · 2023-07-27T06:16:39Z

Let's move all that stuff (both feature gate and linting) back to fn smart_resolve_macro_path, my apologies.

I've removed the relevant changes for the linting from the PR, but I left the feature gating in place as it's just a local addition to the feature gate pass and it seems to fit there quite well. If that's wrong I will happily move it back as well, but I assume the main problem with the other change was the addition of the NodeId parameter to the relevant ast-pass function. As that's not required for the feature gate it might be fine to keep it there?

@rustbot reviewer

estebank · 2023-07-27T07:10:37Z

tests/ui/diagnostic_namespace/requires_path.stderr

+error: cannot find attribute `diagnostic` in this scope
+  --> $DIR/requires_path.rs:3:3
+   |
+LL | #[diagnostic]
+   |   ^^^^^^^^^^


Before stabilization of the namespace, we'll want to customize this error to be something along the lines of "#[diagnostic] needs to be followed by one of *".

compiler/rustc_resolve/src/macros.rs

petrochenkov · 2023-07-27T16:33:21Z

I've removed the relevant changes for the linting from the PR, but I left the feature gating in place as it's just a local addition to the feature gate pass and it seems to fit there quite well.

Yes, that's fine too.

@rustbot author

petrochenkov · 2023-07-28T10:03:11Z

r=me after addressing #111780 (comment) and squashing commits.

Co-authored-by: est31 <[email protected]> Co-authored-by: Esteban Kuber <[email protected]> Co-authored-by: Vadim Petrochenkov <[email protected]>

petrochenkov · 2023-07-28T12:21:20Z

Thanks!
@bors r+

bors · 2023-07-28T12:21:23Z

📌 Commit 5b57666 has been approved by petrochenkov

It is now in the queue for this repository.

bors · 2023-07-28T14:18:31Z

⌛ Testing commit 5b57666 with merge 317ec04...

bors · 2023-07-28T16:10:49Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 317ec04 to master...

rust-timer · 2023-07-29T02:46:15Z

Finished benchmarking commit (317ec04): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-3.0%, -0.8%]	4
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-3.0%, -2.3%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.875s -> 650.027s (-0.13%)

rustbot assigned b-naber May 20, 2023

weiznich commented May 20, 2023

View reviewed changes

compiler/rustc_feature/src/active.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

weiznich force-pushed the diagnostic_namespace branch from 921fe57 to 7945dbb Compare May 20, 2023 09:46

est31 reviewed May 24, 2023

View reviewed changes

compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

est31 reviewed May 26, 2023

View reviewed changes

compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

weiznich force-pushed the diagnostic_namespace branch from 65fe21b to da399fc Compare May 26, 2023 11:52

weiznich mentioned this pull request May 26, 2023

Tracking Issue for #![feature(diagnostic_namespace)] #111996

Closed

3 tasks

petrochenkov self-assigned this May 26, 2023

petrochenkov reviewed May 27, 2023

View reviewed changes

compiler/rustc_hir/src/def.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2023

weiznich force-pushed the diagnostic_namespace branch 2 times, most recently from d48d0d3 to 2408bc6 Compare June 2, 2023 06:52

Noratrieb mentioned this pull request Jun 3, 2023

Add #[rustc_confusables] attribute to allow targeted "no method" error suggestions on standard library types #112239

Merged

petrochenkov added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2023

estebank reviewed Jun 5, 2023

View reviewed changes

compiler/rustc_hir/src/def.rs Outdated Show resolved Hide resolved

weiznich force-pushed the diagnostic_namespace branch from 2408bc6 to 08744dc Compare June 8, 2023 08:33

This comment was marked as resolved.

Sign in to view

weiznich force-pushed the diagnostic_namespace branch from 5faf10b to 1ed72d9 Compare July 27, 2023 06:13

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 27, 2023

This comment has been minimized.

Sign in to view

weiznich force-pushed the diagnostic_namespace branch from 1ed72d9 to 07fd242 Compare July 27, 2023 06:29

This comment has been minimized.

Sign in to view

weiznich force-pushed the diagnostic_namespace branch from 07fd242 to 2f55a69 Compare July 27, 2023 06:50

estebank reviewed Jul 27, 2023

View reviewed changes

petrochenkov reviewed Jul 27, 2023

View reviewed changes

compiler/rustc_resolve/src/macros.rs Outdated Show resolved Hide resolved

compiler/rustc_resolve/src/macros.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2023

weiznich force-pushed the diagnostic_namespace branch from 15a263e to 93d76d2 Compare July 28, 2023 05:14

Introduce the #[diagnostic] attribute namespace

5b57666

Co-authored-by: est31 <[email protected]> Co-authored-by: Esteban Kuber <[email protected]> Co-authored-by: Vadim Petrochenkov <[email protected]>

weiznich force-pushed the diagnostic_namespace branch from 93d76d2 to 5b57666 Compare July 28, 2023 11:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 28, 2023

bors merged commit 317ec04 into rust-lang:master Jul 28, 2023

rustbot added this to the 1.73.0 milestone Jul 28, 2023

estebank mentioned this pull request Aug 3, 2023

Compiler bad error message: E0277 error in Diesel #58968

Open

matthiaskrgr mentioned this pull request Feb 11, 2024

ICE: const parameter types cannot be generic #120941

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Diagnostic namespace #111780

Diagnostic namespace #111780

weiznich commented May 20, 2023

rustbot commented May 20, 2023

rustbot commented May 20, 2023

This comment has been minimized.

matthewjasper commented May 20, 2023

This comment has been minimized.

This comment has been minimized.

weiznich commented Jun 2, 2023

weiznich commented Jun 8, 2023

This comment was marked as resolved.

weiznich commented Jul 27, 2023

This comment has been minimized.

This comment has been minimized.

estebank Jul 27, 2023

petrochenkov commented Jul 27, 2023

petrochenkov commented Jul 28, 2023

petrochenkov commented Jul 28, 2023

bors commented Jul 28, 2023

bors commented Jul 28, 2023

bors commented Jul 28, 2023

rust-timer commented Jul 29, 2023

Diagnostic namespace #111780

Diagnostic namespace #111780

Conversation

weiznich commented May 20, 2023

rustbot commented May 20, 2023

rustbot commented May 20, 2023

This comment has been minimized.

matthewjasper commented May 20, 2023

This comment has been minimized.

This comment has been minimized.

weiznich commented Jun 2, 2023

weiznich commented Jun 8, 2023

This comment was marked as resolved.

weiznich commented Jul 27, 2023

This comment has been minimized.

This comment has been minimized.

estebank Jul 27, 2023

Choose a reason for hiding this comment

petrochenkov commented Jul 27, 2023

petrochenkov commented Jul 28, 2023

petrochenkov commented Jul 28, 2023

bors commented Jul 28, 2023

bors commented Jul 28, 2023

bors commented Jul 28, 2023

rust-timer commented Jul 29, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size