-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split release notes file in two parts #112135
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the MVP! However, this breaks old links everywhere on the internet. We should use our best effort to keep those links alive.
It's a fair point, though I would argue those links are currently already broken, and this PR doesn't fix (most of) them. |
Off the top of my head, probably have this in Version 1.69.0 (2023-04-20)
===========================
<a id="1.69.0-Language"></a>
<a id="1.69.0-Compiler"></a>
<a id="1.69.0-Libraries"></a>
<a id="1.69.0-Stabilized-APIs"></a>
<a id="1.69.0-Cargo"></a>
<a id="1.69.0-Rustdoc"></a>
<a id="1.69.0-Compatibility-Notes"></a>
<a id="1.69.0-Internal-Changes"></a>
Please read [the release note from some other fancy place](https://example.com). And it could be a link to the Git tag. |
* [Documentation is rendered with mdbook instead of the obsolete, in-tree | ||
`rustbook`][39633] | ||
* [The "Unstable Book" documents nightly-only features][ubook] | ||
* [Improve the style of the sid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just have all old links as <a>
anchors right below this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean this
For older releases, see [`RELEASES-old.md`](RELEASES-old.md).
GitHub cannot even render this diff comment properly for large blobs…
This fixes the issue but it breaks all links to pre 1.56 release notes, and we also know it's not a permanent solution: eventually we'll have as much content in the new file and then we'll have to split again (admittedly, that's years out). Having one file per release is also not good IMO because I think many people prefer larger files over smaller ones. My proposal: make one file per edition, this size should be constant: one for edition 2015 and pre-1.0, one for edition 2018, one for edition 2020. Or alternatively, move the edition 2020 stuff into But of course, ideally github would improve their markdown rendering engine to e.g. use a rust based one that stays below timeout limits. Has github been contacted and asked if they can find a way to address the issue without breaking links? Then once edition 2023 comes, we can put the notes for that one into a new file and keep everything else in the old release notes file, keeping that one at a constant size. |
I'm going to go ahead and close this PR -- thanks for putting it up. For 1.70, we linked to the rendered copy on the git tag from the blog post, and all historical releases also have associated tags + rendered markdown attached I believe. I've also posted #112257 which cuts the file down by ~9% without changing the rendering. It sounds like that's not enough for it to start rendering yet, so we may not merge it, but I think it's a better interim step than something like this which breaks links (as others have mentioned). We've also reached out to GitHub (not sure if we did previously, but definitely have now) to ask about this issue and see what we can do there or learn about the particular limits we're hitting to guide a solution. Thanks for doing this work! |
For a while now, it's been a pain that
RELEASES.md
no longer renders as HTML when browsing GitHub (because it's grown too large) -- discussion on Zulip. Split the file in two parts, using 1.56 (as the first release containing 2021 edition support) as the boundary -- the old file is now calledRELEASES-old.md
.RELEASES-old
points toRELEASES.md
at the top, whileRELEASES.md
now points toRELEASES-old.md
at the bottom.Alternatively, we could explicitly call
-old
something more like-pre-1.56
, which has the advantage of being more clear up front but the disadvantage of having to move it when we next want to move the boundary.As another alternative, we could split it up over more files (one per edition?) so that each file will be small enough to render even in the longer term. However, that would make it (slightly) harder to search all of them together.
There are different colors we could paint this particular bikeshed but this seems like a nice incremental improvement.
Fixes #101714.