Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExtendElement, ExtendWith, extend_with #112263

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Remove ExtendElement, ExtendWith, extend_with #112263

merged 1 commit into from
Jun 5, 2023

Conversation

GrishaVar
Copy link
Contributor

Related to #104624, broken up into two commits. The first removes wrapper trait ExtendWith and its only implementer struct ExtendElement. The second may have perf issues so may be reverted/removed if no alternate fix is found; it should be profiled.

r? @scottmcm

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 4, 2023
@scottmcm
Copy link
Member

scottmcm commented Jun 4, 2023 •
edited
Loading

A bunch of these could be extend_trusted, but that shouldn't affect perf (much) -- specialization will go there anyway -- so let's see what it has to say

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 4, 2023
@bors
Copy link
Contributor

bors commented Jun 4, 2023

⌛ Trying commit 60fb684f0881ed11f09b95f10ac06ceb7b59c83d with merge 64f8da738df8d60f9862c26333a23a9807fc7501...

@rust-timer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 4, 2023

☀️ Try build successful - checks-actions
Build commit: 64f8da738df8d60f9862c26333a23a9807fc7501 (64f8da738df8d60f9862c26333a23a9807fc7501)

1 similar comment
@bors
Copy link
Contributor

bors commented Jun 4, 2023

☀️ Try build successful - checks-actions
Build commit: 64f8da738df8d60f9862c26333a23a9807fc7501 (64f8da738df8d60f9862c26333a23a9807fc7501)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (64f8da738df8d60f9862c26333a23a9807fc7501): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.3% [0.2%, 0.5%] 9
Regressions ❌
(secondary)		 0.7% [0.2%, 1.5%] 15
Improvements ✅
(primary)		 -1.9% [-2.2%, -1.6%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-2.2%, 0.5%] 11

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.7% [0.1%, 3.4%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -5.0% [-6.6%, -2.3%] 3
Improvements ✅
(secondary)		 -2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) -2.3% [-6.6%, 3.4%] 5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 37.6% [35.2%, 41.6%] 6
Improvements ✅
(primary)		 -3.2% [-4.4%, -1.8%] 8
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.2% [-4.4%, -1.8%] 8

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.5% [0.1%, 1.1%] 37
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.1%, -0.0%] 4
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.5% [-0.1%, 1.1%] 41

Bootstrap: 647.947s -> 647.684s (-0.04%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 4, 2023
@GrishaVar GrishaVar force-pushed the remove-extend-element branch from 60fb684 to dd2bd03 Compare June 4, 2023 14:00
@GrishaVar
Copy link
Contributor Author

Yep, removing extend_with didn't pass the perf. I've removed that commit, so only the trait and struct are gone now and the history shouldn't be impacted.

@scottmcm
Copy link
Member

scottmcm commented Jun 4, 2023

This is almost certainly fine, but let's check just in case
@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 4, 2023
@bors
Copy link
Contributor

bors commented Jun 4, 2023

⌛ Trying commit dd2bd03 with merge 68e15f2f9b898ba290518cda088c897131d2c512...

@bors
Copy link
Contributor

bors commented Jun 4, 2023

☀️ Try build successful - checks-actions
Build commit: 68e15f2f9b898ba290518cda088c897131d2c512 (68e15f2f9b898ba290518cda088c897131d2c512)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (68e15f2f9b898ba290518cda088c897131d2c512): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)		 1.8% [1.2%, 2.3%] 3
Improvements ✅
(primary)		 -1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.5% [-1.4%, 2.4%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.1% [0.1%, 0.1%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.1% [-0.1%, -0.0%] 23
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.1%, 0.1%] 26

Bootstrap: 645.472s -> 646.928s (0.23%)

@rustbot rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Jun 4, 2023
@scottmcm
Copy link
Member

scottmcm commented Jun 4, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 4, 2023

📌 Commit dd2bd03 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 5, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
@bors
Auto merge of rust-lang#112317 - GuillaumeGomez:rollup-toh0gpo, r=Gui…
408bbd0 
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#112243 (Remove unneeded `Buffer` allocations when `&mut fmt::Write` can be used directly)
 - rust-lang#112263 (Remove ExtendElement, ExtendWith, extend_with)
 - rust-lang#112291 (Disable RustAnalyzer check by default, run Rustfmt check before)
 - rust-lang#112299 (Don't double-print status messages in GHA)
 - rust-lang#112311 (Ignore fluent message reordering in `git blame`)
 - rust-lang#112315 (fix spelling error)

Failed merges:

 - rust-lang#112251 (rustdoc: convert `if let Some()` that always matches to variable)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 200d03a into rust-lang:master Jun 5, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GrishaVar @scottmcm @rust-timer @bors @rustbot