Revised: Added TotalEq/TotalOrd/Clone functionality and related tests to B-tree #11258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrote some tests for the compare/clone/to_str methods. Took out doc comments around tests. Don't allow impls to force public types This code in resolve accidentally forced all types with an impl to become public. This fixes it by default inheriting the privacy of what was previously there and then becoming `true` if nothing else exits. Closes rust-lang#10545 Committing to show work in progress. Everything is still messy, but I want to take this opportunity to get feedback from relevant parties if I can. Recommitting after a bad commit that unnecessarily changed files.
as some style changes.
| @@ -14,8 +14,10 @@ | |||
| //! Starting implementation of a btree for rust. | |||
| //! Structure inspired by github user davidhalperin's gist. | |||
|
|
|||
|
|
|||
| #[allow(attribute_usage)]; | |||
| #[feature(globs)]; | |||
There was a problem hiding this comment.
I don't see any globs in this commit. Why turn on the feature?
There was a problem hiding this comment.
I think it was left in by accident. It was being used, but I ultimately ended up taking out the globs. There are also a few commented-out lines I meant to delete so I think I'll push a new commit shortly that fixes these things and anything else that needs fixing.
|
@niftynif: You don't need to open up a new PR everytime, just do your changes locally then |
|
Great, thanks for the advice. :) |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 31, 2023
Resolve type aliases in `type_certainty` Fixes rust-lang#11256 changelog: `unwrap_or_default`: Fix ICE when local types are declared using alias types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the debacle that was the previous PR, I decided to close and start again. This adds TotalEq, TotalOrd, and Clone to each part of the btree structure. r? @catamorphism