-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow comparing Box
es with different allocators
#112628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Jun 14, 2023
gootorov
commented
Jun 14, 2023
This comment has been minimized.
This comment has been minimized.
gootorov
force-pushed
the
box_alloc_partialeq
branch
from
June 14, 2023 17:37
9598a11
to
5ca1a6a
Compare
Noratrieb
reviewed
Jun 14, 2023
gootorov
force-pushed
the
box_alloc_partialeq
branch
from
June 14, 2023 18:18
5ca1a6a
to
3d3c6cd
Compare
gootorov
force-pushed
the
box_alloc_partialeq
branch
from
June 18, 2023 03:22
3d3c6cd
to
001b081
Compare
Corresponding ACP: rust-lang/libs-team#241 |
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 27, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 27, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#112207 (Add trustzone and virtualization target features for aarch32.) - rust-lang#112454 (Make compiletest aware of targets without dynamic linking) - rust-lang#112628 (Allow comparing `Box`es with different allocators) - rust-lang#112692 (Provide more context for `rustc +nightly -Zunstable-options` on stable) - rust-lang#112972 (Make `UnwindAction::Continue` explicit in MIR dump) - rust-lang#113020 (Add tests impl via obj unless denied) - rust-lang#113084 (Simplify some conditions) - rust-lang#113103 (Normalize types when applying uninhabited predicate.) r? `@ghost` `@rustbot` modify labels: rollup
This PR appears to have introduced a regression. The following program compiles before this PR, but not after: #[derive(Debug, PartialEq)]
struct Expr;
#[allow(dead_code)]
fn from_exprs(exprs: Vec<Box<Expr>>) {
debug_assert_ne!(exprs, vec![], "exprs must not be empty");
} E.g.:
I noticed this while trying to build
|
smoelius
added a commit
to smoelius/necessist
that referenced
this pull request
Jul 2, 2023
Until the following is resolved: rust-lang/rust#112628 (comment)
smoelius
added a commit
to smoelius/necessist
that referenced
this pull request
Jul 3, 2023
Until the following is resolved: rust-lang/rust#112628 (comment)
smoelius
added a commit
to trailofbits/necessist
that referenced
this pull request
Jul 3, 2023
Until the following is resolved: rust-lang/rust#112628 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, comparing
Box
es over different allocators is not allowed:This PR lifts this limitation