-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gha problem matcher #112787
Add gha problem matcher #112787
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jyn514 (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
can you move this to the existing matcher at |
c1903af
to
7c7cc12
Compare
ah whoops, thanks! |
this looks good :) i worry a little that we won't notice when the regexes get outdated but the failure mode is just that the logs won't show up on the pr anymore so i don't mind merging this speculatively and fixing it later if it breaks. @bors r+ rollup |
yea... I have looked into it, but gha is untestable without significant effort (writing github API queries to check if some dummy branches emit those messages) |
…=jyn514 Add gha problem matcher These regexes capture rustfmt errors, panics and regular Rust errors in CI and automatically add messages in the diff view. This should make it simpler to quickly see what went wrong without having to scroll through CI logs. We can fine tune the regexes or add more matchers after having a look at how it actually works in practice The relevant documentation can be found at https://github.com/actions/toolkit/blob/main/docs/problem-matchers.md r? `@jyn514`
I'm concerned this is going to generate a lot of false positives. For example, on this PR with a passing build, it generates 6 pages of errors for me. Is there some way to limit those, or maybe suppress the output in the tests that generate them? |
imo we should fix the libtest framework to properly capture the panics :/ i think it's related to thread spawning? i could have sworn there was a PR to fix it a couple years ago but maybe it didn't get merged for some reason. |
We can remove the panic regex for now. |
@bors r- |
7c7cc12
to
13aa0dc
Compare
I replaced the panic regex with one for internal compiler errors. Let's see what CI says |
I don't see any popups in the diff. @bors r+ rollup |
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#112232 (Better error for non const `PartialEq` call generated by `match`) - rust-lang#112499 (Fix python linting errors) - rust-lang#112596 (Suggest correct signature on missing fn returning RPITIT/AFIT) - rust-lang#112606 (Alter `Display` for `Ipv6Addr` for IPv4-compatible addresses) - rust-lang#112781 (Don't consider TAIT normalizable to hidden ty if it would result in impossible item bounds) - rust-lang#112787 (Add gha problem matcher) - rust-lang#112799 (Clean up "doc(hidden)" check) - rust-lang#112803 (Format the examples directory of cg_clif) r? `@ghost` `@rustbot` modify labels: rollup
These regexes capture rustfmt errors, panics and regular Rust errors in CI and automatically add messages in the diff view. This should make it simpler to quickly see what went wrong without having to scroll through CI logs.
We can fine tune the regexes or add more matchers after having a look at how it actually works in practice
The relevant documentation can be found at https://github.com/actions/toolkit/blob/main/docs/problem-matchers.md
r? @jyn514