Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #112839

Merged
merged 19 commits into from
Jun 20, 2023
Merged

Rollup of 6 pull requests #112839

merged 19 commits into from
Jun 20, 2023

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

eval-exec and others added 19 commits June 18, 2023 01:56
One shouldn't need a nightly compiler in order to ~~have fun~~ call a
function many times.
…-overflow, r=ChrisDenton

Fix windows `Socket::connect_timeout` overflow

This PR want to close rust-lang#112405

- [x] add unit test
…or-same-as-item-color, r=notriddle,GuillaumeGomez

Rustdoc: search: color item type and reduce size to avoid clashing

- rustdoc: search: color item type same as item
- rustdoc: search: reduce item type size to 0.875rem to avoid clashing with path and item
…ent-checking, r=compiler-errors

Sort the errors from arguments checking so that suggestions are handled properly

Fixes rust-lang#112507

The algorithm of `find_issue` does not make sure the index comes out in order, which will make suggesting `remove` or `add` arguments broken in some cases.

Modifying the algorithm to obey order involves much more trivial change, so it's better to order the `errors` after iterations.
change binders from tuple structs to named fields
…-obk

Fix linker failures when #[global_allocator] is used in a dependency

Fixes rust-lang#112715
Disable feature(unboxed_closures, fn_traits) in weird-exprs

One shouldn't need a nightly compiler in order to ~~have fun~~ call a function many times.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 20, 2023
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=6 rollup=never

@bors
Copy link
Contributor

bors commented Jun 20, 2023

📌 Commit 2368fa2 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2023
@bors
Copy link
Contributor

bors commented Jun 20, 2023

⌛ Testing commit 2368fa2 with merge 1b6d4cd...

@bors
Copy link
Contributor

bors commented Jun 20, 2023

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 1b6d4cd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 20, 2023
@bors bors merged commit 1b6d4cd into rust-lang:master Jun 20, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 20, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#112819 96ba7ac54d99d5d743c1e4d2f55f1278406cca88
#112794 afda83dd951db959d13deb24d3507c72c6ee3a70
#112786 0e5e062dd32ce095a77e5bf8fa6aba2bfb8530e1
#112762 e4cb4c1cbb1a507539aed843fadfd01e3a7d3311
#112720 9e94f81eaad1cf0dcee9e3b77f8cb9bff661800f
#112464 78e81e5d6e5d4671c7c16342d04ec85d4360af68

previous master: 6fc0273b5a

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@GuillaumeGomez GuillaumeGomez deleted the rollup-jc5nqug branch June 20, 2023 16:05
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1b6d4cd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 655.831s -> 657.549s (0.26%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants