-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate TyCtxt::predicates_of
and ParamEnv::caller_bounds
to Clause
#112938
Conversation
TyCtxt::predicates_of
and ParamEnv::caller_bounds
to Clause
cfce712
to
146bd72
Compare
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred in cc @BoxyUwU Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
146bd72
to
86b7a70
Compare
☔ The latest upstream changes (presumably #112987) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after rebase
86b7a70
to
374173c
Compare
@bors r=oli-obk |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b5e51db): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 661.833s -> 661.464s (-0.06%) |
cargo and bitmaps noise, stabilizing from the previous merge. @rustbot label: +perf-regression-triaged |
it's quite unsightly and maybe it would be better to use directly Clauses instead of Predicates (from rustc_middle::ty), Also, it might be the reason the translation is a bit shuffled, so, maybe it would be better to change those modifications
The last big change in the series.
I will follow-up with additional filed issues once this PR lands:
TypeFoldable<TyCtxt<'tcx>> for ty::Clause<'tcx>
implementation less weird:rust/compiler/rustc_middle/src/ty/structural_impls.rs
Line 672 in 2efe091
pred
andpredicates
toclause
if they're actually clauses around the codebaseToPredicate
impls are acutally still needed, or prune them if they're notr? @ghost until the other branch lands