Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite most diagnostics as translatable within resolve/imports #112979

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Rewrite most diagnostics as translatable within resolve/imports #112979

merged 1 commit into from
Jun 26, 2023

Conversation

NotStirred
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2023

r? @fee1-dead

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 23, 2023
@NotStirred NotStirred requested a review from fee1-dead June 24, 2023 17:15
fee1-dead
fee1-dead approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. r=me after addressing nits

@fee1-dead
Copy link
Member

Thanks. One last thing: could you squash the commits into one?

@NotStirred
Add translatable diagnostic for import resolution strings
b7d6032 
Add translatable diagnostic for cannot be reexported error
also added for subdiagnostics

Add translatable diagnostics for resolve_glob_import errors

Add translatable diag for unable to determine import resolution

Add translatable diag for is not directly importable
@NotStirred NotStirred force-pushed the translatable_diag/resolve_imports branch from fc6d2a1 to b7d6032 Compare June 25, 2023 07:30
@fee1-dead
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 26, 2023

📌 Commit b7d6032 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 26, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 26, 2023
@bors
Auto merge of rust-lang#113049 - matthiaskrgr:rollup-41wo5w8, r=matth…
27e10c5 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#111326 (Add support for NetBSD/aarch64-be (big-endian arm64).)
 - rust-lang#112559 (Add esp-idf missing targets)
 - rust-lang#112840 (doc: loongarch: Update maintainers)
 - rust-lang#112955 (CI: cancel in-progress workflow runs after a push)
 - rust-lang#112979 (Rewrite most diagnostics as translatable within resolve/imports)
 - rust-lang#113034 (Switch some more Steps to `builder.msg`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 005d860 into rust-lang:master Jun 26, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fee1-dead fee1-dead fee1-dead approved these changes

@chenyukang chenyukang chenyukang approved these changes

Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@NotStirred @rustbot @fee1-dead @bors @chenyukang