-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
track spans for assumed_wf_types
#113150
track spans for assumed_wf_types
#113150
Conversation
Some changes occurred in engine.rs, potentially modifying the public API of These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 0e9869ecfe3dff80af43d72b541932be1f92a07f with merge 178fc4cd71e286fec0c6b093ffbb2336b6ee743a... |
This comment has been minimized.
This comment has been minimized.
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit e674a8f with merge 5de9f908d29a047fd1d156c59d19cc20d8de1896... |
💔 Test failed - checks-actions |
@bors try |
⌛ Trying commit e674a8f with merge 7e0021bcf980c73a6cd8664e751d69d7ee4f55a7... |
💔 Test failed - checks-actions |
There are no other try builds so @bors try |
⌛ Trying commit e674a8f with merge 418e549bd05a1e0df4228336285ddf6ab8dde282... |
💥 Test timed out |
😭 @bors try |
⌛ Trying commit e674a8f with merge bd8bf08383494e921169d24785358f8f36a00984... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (bd8bf08383494e921169d24785358f8f36a00984): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 660.993s -> 662.06s (0.16%) |
handled in #113086 |
split out of #113086 to check whether this causes the perf regression.
r? @oli-obk