Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track spans for assumed_wf_types #113150

Closed
wants to merge 1 commit into from
Closed

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jun 29, 2023

split out of #113086 to check whether this causes the perf regression.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 29, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2023

Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.

cc @lcnr, @compiler-errors

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@lcnr
Copy link
Contributor Author

lcnr commented Jun 29, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 29, 2023
@bors
Copy link
Contributor

bors commented Jun 29, 2023

⌛ Trying commit 0e9869ecfe3dff80af43d72b541932be1f92a07f with merge 178fc4cd71e286fec0c6b093ffbb2336b6ee743a...

@rust-log-analyzer

This comment has been minimized.

@lcnr lcnr force-pushed the assumed_wf_types branch from 0e9869e to e674a8f Compare June 29, 2023 07:05
@lcnr
Copy link
Contributor Author

lcnr commented Jun 29, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jun 29, 2023

⌛ Trying commit e674a8f with merge 5de9f908d29a047fd1d156c59d19cc20d8de1896...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Jun 29, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@lcnr
Copy link
Contributor Author

lcnr commented Jun 29, 2023

@bors try

@bors
Copy link
Contributor

bors commented Jun 29, 2023

⌛ Trying commit e674a8f with merge 7e0021bcf980c73a6cd8664e751d69d7ee4f55a7...

@bors
Copy link
Contributor

bors commented Jun 29, 2023

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@compiler-errors
Copy link
Member

There are no other try builds so @bors try

@bors
Copy link
Contributor

bors commented Jun 29, 2023

⌛ Trying commit e674a8f with merge 418e549bd05a1e0df4228336285ddf6ab8dde282...

@bors
Copy link
Contributor

bors commented Jun 29, 2023

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2023
@compiler-errors
Copy link
Member

😭

@bors try

@bors
Copy link
Contributor

bors commented Jun 29, 2023

⌛ Trying commit e674a8f with merge bd8bf08383494e921169d24785358f8f36a00984...

@bors
Copy link
Contributor

bors commented Jun 30, 2023

☀️ Try build successful - checks-actions
Build commit: bd8bf08383494e921169d24785358f8f36a00984 (bd8bf08383494e921169d24785358f8f36a00984)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bd8bf08383494e921169d24785358f8f36a00984): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.5%, 1.3%] 22
Regressions ❌
(secondary)
0.7% [0.3%, 1.2%] 10
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.8% [0.5%, 1.3%] 22

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.7% [0.4%, 0.9%] 2
Regressions ❌
(secondary)
1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)
-1.5% [-5.7%, -0.4%] 6
Improvements ✅
(secondary)
-2.3% [-2.9%, -1.7%] 2
All ❌✅ (primary) -1.0% [-5.7%, 0.9%] 8

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 660.993s -> 662.06s (0.16%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 30, 2023
@lcnr
Copy link
Contributor Author

lcnr commented Jul 3, 2023

handled in #113086

@lcnr lcnr closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants