Rollup of 5 pull requests #113223

TaKO8Ki · 2023-07-01T05:45:14Z

Successful merges:

Make simd_shuffle_indices use valtrees #112718 (Make simd_shuffle_indices use valtrees)
Better messages for next on a iterator inside for loops #113174 (Better messages for next on a iterator inside for loops)
Backtrace 0.3.68 #113176 (Backtrace 0.3.68)
Error when RPITITs' hidden types capture more lifetimes than their trait definitions #113182 (Error when RPITITs' hidden types capture more lifetimes than their trait definitions)
Fix associated items effective visibility calculation for type privacy lints #113196 (Fix associated items effective visibility calculation for type privacy lints)

r? @ghost
@rustbot modify labels: rollup

… type constants

…y lints

…, r=cjgillot Make simd_shuffle_indices use valtrees This removes the second-to-last user of the `destructure_mir_constant` query. So in a follow-up we can remove the query and just move the query provider function directly into pretty printing (which is the last user). cc ``@rust-lang/clippy`` there's a small functional change, but I think it is correct?

…next, r=compiler-errors Better messages for next on a iterator inside for loops Fixes rust-lang#102972

…=thomcc Backtrace 0.3.68 Uptakes these releases: - https://github.com/rust-lang/backtrace-rs/releases/tag/0.3.68 - https://github.com/rust-lang/flate2-rs/releases/tag/1.0.26 r? `@thomcc`

…ures, r=oli-obk Error when RPITITs' hidden types capture more lifetimes than their trait definitions This implements a stricter set of captures rules for RPITITs. They now may only capture: 1. Lifetimes from the impl header (both the self type and any trait substs -- we may want to restrict just to the self type's lifetimes, but the PR makes that easy to do, too) 2. Lifetimes mentioned by the `impl Trait` in the trait method's definition. Namely, they may not mention lifetimes from the method (early or late) that are not mentioned in the `impl Trait`. cc rust-lang#105258 which I think was trying to do this too, though I'm not super familiar with what exactly differs from that or why that one was broken. cc rust-lang#112194 (doesn't fix this issue per se, because it's still an open question, but I think this is objectively better than the status quo, and gets us closer to resolving that issue.) Technically is a fix for the ICE in rust-lang#108580, but it turns that issue into an error now. We can decide separately whether or not nested RPITITs should capture lifetimes from their parents. r? `@oli-obk`

Fix associated items effective visibility calculation for type privacy lints Fixes rust-lang#113126 (comment).

TaKO8Ki · 2023-07-01T05:45:29Z

@bors r+ rollup=never p=5

bors · 2023-07-01T05:45:30Z

📌 Commit 181861c has been approved by TaKO8Ki

It is now in the queue for this repository.

rust-log-analyzer · 2023-07-01T05:49:14Z

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:c85c95e3d7251135ab7dc9ce3241c5835cc595a9)
Download action repository 'actions/upload-artifact@v3' (SHA:0b7f8abb1508181956e8e162db84b466c27e18ce)
Complete job name: PR - mingw-check-tidy
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  CI_JOB_NAME: mingw-check-tidy
---
Building wheels for collected packages: reuse
  Building wheel for reuse (pyproject.toml): started
  Building wheel for reuse (pyproject.toml): finished with status 'done'
  Created wheel for reuse: filename=reuse-1.1.0-cp310-cp310-manylinux_2_35_x86_64.whl size=180116 sha256=351235b2326fb4db7a18e257e13ce7896c5f77339521e2c2612e71e154800a19
  Stored in directory: /tmp/pip-ephem-wheel-cache-crxgvgb3/wheels/c2/3c/b9/1120c2ab4bd82694f7e6f0537dc5b9a085c13e2c69a8d0c76d
Installing collected packages: boolean-py, binaryornot, setuptools, reuse, python-debian, markupsafe, license-expression, jinja2, chardet
  Attempting uninstall: setuptools
    Found existing installation: setuptools 59.6.0
    Not uninstalling setuptools at /usr/lib/python3/dist-packages, outside environment /usr
---
Successfully tagged rust-ci:latest
Built container sha256:b02411861b92d2be4ec117a0a6f4d16fc5d297801510e6b38b2d49c2f0cf307b
Uploading finished image to https://ci-caches.rust-lang.org/docker/39289e18f1ac1b1a573d1a3c658528cab0cbfec4029e2def8ed615ecd4b1295e23213ab5b134f4a50a4bd45af0a8a4266b7571ba256dc217696d0f040efcd003

<botocore.awsrequest.AWSRequest object at 0x7f9b06cbdc90>
gzip: stdout: Broken pipe
xargs: docker: terminated by signal 13
[CI_JOB_NAME=mingw-check-tidy]
[CI_JOB_NAME=mingw-check-tidy]
---
##[endgroup]
fmt check
tidy check
tidy: Skipping binary file check, read-only filesystem
thread 'deps (.)' panicked at 'cmd.exec() failed with `cargo metadata` exited with an error: error: failed to write /checkout/Cargo.lock
Caused by:
  failed to open: /checkout/Cargo.lock

Caused by:

bors · 2023-07-01T07:02:09Z

⌛ Testing commit 181861c with merge 43fd7c9a30612f9036c9a6a513dfd12c47a89963...

TaKO8Ki · 2023-07-01T07:03:28Z

@bors retry

bors · 2023-07-01T07:03:38Z

⌛ Testing commit 181861c with merge ad60dcc77d36d5342bdf2871e77fd06d566d4113...

bors · 2023-07-01T07:07:43Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-07-01T07:08:31Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-log-analyzer · 2023-07-01T07:13:52Z

The job x86_64-gnu-nopt failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

TaKO8Ki · 2023-07-01T09:03:31Z

@bors retry

bors · 2023-07-01T09:26:07Z

⌛ Testing commit 181861c with merge 6a1af3eed86a8cf67ceafd847d8be14c97c59646...

bors · 2023-07-01T09:31:26Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-07-01T09:33:48Z

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING] tool::Tidy { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu } -- 0.000
fmt check
tidy check
tidy: Skipping binary file check, read-only filesystem
thread 'deps (.)' panicked at 'cmd.exec() failed with `cargo metadata` exited with an error: error: failed to write /checkout/Cargo.lock
Caused by:
  failed to open: /checkout/Cargo.lock

Caused by:

TaKO8Ki · 2023-07-01T11:39:31Z

@bors retry

bors · 2023-07-01T14:28:53Z

⌛ Testing commit 181861c with merge 505c197a9e1fa4d836678e0e7fad07e948a3ee8e...

rust-log-analyzer · 2023-07-01T14:31:59Z

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING] tool::ToolBuild { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu, tool: "tidy", path: "src/tools/tidy", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [], allow_features: "" } -- 23.924
[TIMING] tool::Tidy { compiler: Compiler { stage: 0, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu } -- 0.000
fmt check
tidy check
thread 'deps (.)' panicked at 'cmd.exec() failed with `cargo metadata` exited with an error: error: failed to write /checkout/Cargo.lock
Caused by:
  failed to open: /checkout/Cargo.lock

Caused by:

bors · 2023-07-01T14:32:29Z

💔 Test failed - checks-actions

oli-obk and others added 16 commits June 26, 2023 09:34

Make simd_shuffle_indices use valtrees

168de14

Move mir const to valtree conversion to its own method.

acdfec6

Assert that we don't convert unevaluated MIR promoteds to unevaluated…

1c992c0

… type constants

Update std to backtrace 0.3.68

e21d56a

Update flate2 to dedup miniz_oxide

2150451

Error for RPITIT hidden tys that capture more than their trait defn

d567e4f

Flip the order of binder instantiation for better diagnostics

473c88d

Adapt tests from rust-lang#105258

8ad5ea7

Better messages for next in a iterator inside for loops

44a8a8d

add typecheck for iterator

4189faa

Fix associated items effective visibility calculation for type privac…

f9a4db7

…y lints

Rollup merge of rust-lang#113174 - chenyukang:yukang-fix-102972-loop-…

e084744

…next, r=compiler-errors Better messages for next on a iterator inside for loops Fixes rust-lang#102972

Rollup merge of rust-lang#113176 - workingjubilee:backtrace-0.3.68, r…

b2ce4f4

…=thomcc Backtrace 0.3.68 Uptakes these releases: - https://github.com/rust-lang/backtrace-rs/releases/tag/0.3.68 - https://github.com/rust-lang/flate2-rs/releases/tag/1.0.26 r? `@thomcc`

Rollup merge of rust-lang#113196 - Bryanskiy:assoc_item, r=petrochenkov

181861c

Fix associated items effective visibility calculation for type privacy lints Fixes rust-lang#113126 (comment).

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 1, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 1, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 1, 2023

TaKO8Ki closed this Jul 1, 2023

TaKO8Ki deleted the rollup-a84rnxa branch July 1, 2023 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #113223

Rollup of 5 pull requests #113223

TaKO8Ki commented Jul 1, 2023

TaKO8Ki commented Jul 1, 2023

bors commented Jul 1, 2023

rust-log-analyzer commented Jul 1, 2023

bors commented Jul 1, 2023

TaKO8Ki commented Jul 1, 2023

bors commented Jul 1, 2023

bors commented Jul 1, 2023

rust-log-analyzer commented Jul 1, 2023

rust-log-analyzer commented Jul 1, 2023

TaKO8Ki commented Jul 1, 2023

bors commented Jul 1, 2023

bors commented Jul 1, 2023

rust-log-analyzer commented Jul 1, 2023

TaKO8Ki commented Jul 1, 2023

bors commented Jul 1, 2023

rust-log-analyzer commented Jul 1, 2023

bors commented Jul 1, 2023

Rollup of 5 pull requests #113223

Rollup of 5 pull requests #113223

Conversation

TaKO8Ki commented Jul 1, 2023

TaKO8Ki commented Jul 1, 2023

bors commented Jul 1, 2023

rust-log-analyzer commented Jul 1, 2023

bors commented Jul 1, 2023

TaKO8Ki commented Jul 1, 2023

bors commented Jul 1, 2023

bors commented Jul 1, 2023

rust-log-analyzer commented Jul 1, 2023

rust-log-analyzer commented Jul 1, 2023

TaKO8Ki commented Jul 1, 2023

bors commented Jul 1, 2023

bors commented Jul 1, 2023

rust-log-analyzer commented Jul 1, 2023

TaKO8Ki commented Jul 1, 2023

bors commented Jul 1, 2023

rust-log-analyzer commented Jul 1, 2023

bors commented Jul 1, 2023