Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Step for ascii::Char #113295

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Conversation

clarfonthey
Copy link
Contributor

@clarfonthey clarfonthey commented Jul 3, 2023

This allows iterating over ranges of ascii::Char, similarly to ranges of char.

Note that ascii::Char is still unstable, tracked in #110998.

@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 3, 2023
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Jul 8, 2023

☔ The latest upstream changes (presumably #113491) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Jul 21, 2023

☔ The latest upstream changes (presumably #105571) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

library/core/src/iter/range.rs Outdated Show resolved Hide resolved
library/core/src/iter/range.rs Outdated Show resolved Hide resolved
library/core/tests/lib.rs Outdated Show resolved Hide resolved
@clarfonthey
Copy link
Contributor Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2023
@clarfonthey
Copy link
Contributor Author

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 12, 2023
@bors
Copy link
Contributor

bors commented Aug 13, 2023

☔ The latest upstream changes (presumably #114786) made this pull request unmergeable. Please resolve the merge conflicts.

@clarfonthey
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Aug 14, 2023
@cuviper
Copy link
Member

cuviper commented Sep 1, 2023

Note that ascii::Char is still unstable, tracked in #110998.

Please make sure this gets added to that tracking issue!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 1, 2023

📌 Commit ef33054 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2023
@bors
Copy link
Contributor

bors commented Sep 2, 2023

⌛ Testing commit ef33054 with merge f9ba43c...

@bors
Copy link
Contributor

bors commented Sep 2, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing f9ba43c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 2, 2023
@bors bors merged commit f9ba43c into rust-lang:master Sep 2, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 2, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f9ba43c): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)
4.8% [4.8%, 4.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-7.4% [-7.4%, -7.4%] 1
All ❌✅ (primary) 0.6% [0.6%, 0.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.838s -> 629.86s (-0.16%)
Artifact size: 316.58 MiB -> 316.61 MiB (0.01%)

@clarfonthey clarfonthey deleted the ascii-step branch September 2, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants