Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] Test revert of #113320 #113587

Closed
wants to merge 1 commit into from
Closed

[perf] Test revert of #113320 #113587

wants to merge 1 commit into from

Conversation

lqd
Copy link
Member

@lqd lqd commented Jul 11, 2023

This tries to revert the entirety of #113320, to see if it caused a regression in rollup #113370, since the results reverting a single commit in #113400 were confusing.

r? @ghost

…ery, r=petrochenkov,BoxyUwU"

This reverts commit 0334b64, reversing
changes made to 5c7a7d9.
@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 11, 2023
@lqd
Copy link
Member Author

lqd commented Jul 11, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 11, 2023
@bors
Copy link
Contributor

bors commented Jul 11, 2023

⌛ Trying commit ebd6847 with merge 00590a9fe9f13af5f15914a6b4a1e2e5bdf67b7e...

@lqd lqd mentioned this pull request Jul 11, 2023
@bors
Copy link
Contributor

bors commented Jul 11, 2023

☀️ Try build successful - checks-actions
Build commit: 00590a9fe9f13af5f15914a6b4a1e2e5bdf67b7e (00590a9fe9f13af5f15914a6b4a1e2e5bdf67b7e)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (00590a9fe9f13af5f15914a6b4a1e2e5bdf67b7e): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.2%, -3.2%] 1
All ❌✅ (primary) 0.7% [0.7%, 0.7%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 657.118s -> 657.094s (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 12, 2023
@oli-obk oli-obk closed this Jul 12, 2023
@lqd lqd deleted the oli-perf branch July 12, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants