Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused bootstrap::util::CiEnv enum #113731

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Remove unused bootstrap::util::CiEnv enum #113731

merged 1 commit into from
Jul 16, 2023

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 15, 2023

the right one is build_helper::CiEnv; this one wasn't even used.

@jyn514
Remove unused bootstrap::util::CiEnv enum
6f589d5 
the right one is `build_helper::CiEnv`; this one wasn't even used.
@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2023

r? @ozkanonur

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 15, 2023
@jyn514 jyn514 added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Jul 15, 2023
@onur-ozkan
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 15, 2023

📌 Commit 6f589d5 has been approved by ozkanonur

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2023
@jyn514 jyn514 mentioned this pull request Jul 15, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2023
@bors
Auto merge of rust-lang#113738 - jyn514:rollup-mjcya4c, r=jyn514
2c718d1 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#113643 (bootstrap: Clean up try_run)
 - rust-lang#113731 (Remove unused `bootstrap::util::CiEnv` enum)
 - rust-lang#113737 (update mailmap for myself)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0a299f6 into rust-lang:master Jul 16, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 16, 2023
@jyn514 jyn514 deleted the ci-env branch July 16, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@onur-ozkan onur-ozkan

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jyn514 @rustbot @onur-ozkan @bors