-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert builtin "global" late lints to run per module #113734
Conversation
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit f79296b3077e49380fb3b70761fab33d65e413a0 with merge 48a02fa0c7ccb590217148ef329202c4883e7230... |
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (48a02fa0c7ccb590217148ef329202c4883e7230): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 657.257s -> 656.692s (-0.09%) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cc @rust-lang/rustdoc for the change to missing docs lint. |
…chenkov Simplify native_libs query Drive-by cleanup I saw while implementing rust-lang#113734
…chenkov Simplify native_libs query Drive-by cleanup I saw while implementing rust-lang#113734
…chenkov Simplify native_libs query Drive-by cleanup I saw while implementing rust-lang#113734
r? compiler |
This comment was marked as resolved.
This comment was marked as resolved.
…trochenkov Make test harness lint about unnnameable tests. Implementation of rust-lang#113734 (comment) About the options suggested in rust-lang#36629 (comment): adding this case to unused_attribute was just more complicated. I'll try to understand a bit more what you had in mind in rust-lang/rfcs#2471 (comment) This was just simpler to do in a standalone PR. I'll remove the corresponding changes from rust-lang#113734 later. r? `@petrochenkov`
@bors r+ |
Make test harness lint about unnnameable tests. Implementation of rust-lang/rust#113734 (comment) About the options suggested in rust-lang/rust#36629 (comment): adding this case to unused_attribute was just more complicated. I'll try to understand a bit more what you had in mind in rust-lang/rfcs#2471 (comment) This was just simpler to do in a standalone PR. I'll remove the corresponding changes from rust-lang/rust#113734 later. r? `@petrochenkov`
☀️ Test successful - checks-actions |
Finished benchmarking commit (67626b8): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 650.338s -> 649.856s (-0.07%) |
Awesome results! |
The compiler currently has 4 non-incremental lints:
clashing_extern_declarations
;missing_debug_implementations
;changed by Make test harness lint about unnnameable tests. #114414unnameable_test_items
;missing_docs
.Non-incremental lints get reexecuted for each compilation, which is slow. Moreover, those lints are allow-by-default, so run for nothing most of the time. This PR attempts to make them more incremental-friendly.
clashing_extern_declarations
is moved to a standalone query.missing_debug_implementation
can usenon_blanket_impls_for_ty
instead of recomputing it.missing_docs
is harder as it needs to track if there is adoc(hidden)
module surrounding. I hack around this using the lint level engine. That's easy to implement and allows to re-enable the lint for a re-exported module, while a more proper solution would reuse the same device asunnameable_test_items
.