-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #113890
Rollup of 7 pull requests #113890
Conversation
…tor appearance (padding) to look identical on Firefox. New versions of Firefox appear to have changed behavior to agree with Chrome.
… r=fmease,GuillaumeGomez rustdoc: fix position of `default` in method rendering With the following code: ```rs #![feature(specialization)] pub trait A { unsafe fn a(); } impl A for () { default unsafe fn a() {} } ``` rustdoc would render the `impl` of `a` as ```rs unsafe default fn a() ``` which is inconsistent with the actual position of `default`. This PR fixes this issue.
…wesleywiser Permit pre-evaluated constants in simd_shuffle fixes rust-lang#113500
Avoid another gha group nesting fixes rust-lang#113798 (`x test error_index_generator` did not work locally anymore) r? ``@jyn514``
Add Foreign, Never, FnDef, Closure and Generator tys to SMIR r? ``@oli-obk``
…ng-self-ty, r=compiler-errors new solver: don't consider blanket impls multiple times only consider candidates which rely on the self type in `assemble_candidates_after_normalizing_self_ty`. r? ``@compiler-errors``
…ctor-padding, r=GuillaumeGomez Remove outdated Firefox-specific CSS for search's crate selector appearance Remove adjustments that used to be necessary for search's crate selector appearance (padding) to look identical on Firefox. New versions of Firefox appear to have changed behavior to agree with Chrome. As briefly discussed in rust-lang#98855 (comment) r? ``@GuillaumeGomez``
…e, r=davidtwco Don't translate compiler-internal bug messages These are not very useful to be translated, as * translators would get really weird and bad english versions to start out from, * compiler devs have to do some work for what is supposed to be dead code and just a sanity check, * the target audience is other compiler devs. r? `@davidtwco`
@bors r+ rollup=never p=7 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: 06a53ddc0b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (092e4f4): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 649.387s -> 650.008s (0.10%) |
@rustbot label: +perf-regression-triaged (a sole 0.2% regression to a secondary benchmark is not worth taking time to dissect IMO.) |
Successful merges:
default
in method rendering #110765 (rustdoc: fix position ofdefault
in method rendering)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup